From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Riemer Subject: Re: [PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline Date: Wed, 10 Jul 2013 18:34:38 +0200 Message-ID: <51DD8D1E.6000605@profitbricks.com> References: <1373391385-4978-1-git-send-email-roland@kernel.org> <51DD714D.4080001@profitbricks.com> <51DD7F10.1040104@acm.org> <51DD7F83.4070402@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51DD7F83.4070402-HInyCGIudOg@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Roland Dreier , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Vu Pham , David Dillow List-Id: linux-rdma@vger.kernel.org Hi Bart, my patch looks very similar. I was in a company meeting so I couldn't send it fast enough. Can be applied that way! Thanks! Cheers, Sebastian On 10.07.2013 17:36, Bart Van Assche wrote: > If the transport layer is offline it is more appropriate to let > srp_abort() return FAST_IO_FAIL instead of SUCCESS. > > Signed-off-by: Bart Van Assche > Reported-by: Sebastian Riemer > Cc: David Dillow > Cc: Roland Dreier > Cc: Vu Pham > --- > drivers/infiniband/ulp/srp/ib_srp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index 9d8b46e..f93baf8 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -1753,8 +1753,7 @@ static int srp_abort(struct scsi_cmnd *scmnd) > if (!req || !srp_claim_req(target, req, scmnd)) > return FAILED; > if (srp_send_tsk_mgmt(target, req->index, scmnd->device->lun, > - SRP_TSK_ABORT_TASK) == 0 || > - target->transport_offline) > + SRP_TSK_ABORT_TASK) == 0) > ret = SUCCESS; > else if (target->transport_offline) > ret = FAST_IO_FAIL; > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html