All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <menon.nishanth@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] dra7xx_evm: add SPL API, QSPI, and serial flash support
Date: Wed, 10 Jul 2013 18:58:53 -0500	[thread overview]
Message-ID: <51DDF53D.1070200@gmail.com> (raw)
In-Reply-To: <51DD65EF.1030501@ti.com>

[...]
>> diff --git a/board/ti/dra7xx/mux_data.h b/board/ti/dra7xx/mux_data.h
>> index 338a241..2441c55 100644
>> --- a/board/ti/dra7xx/mux_data.h
>> +++ b/board/ti/dra7xx/mux_data.h
>> @@ -53,5 +53,15 @@ const struct pad_conf_entry core_padconf_array_essential[] = {
>>   	{UART1_RTSN, (IEN | PTU | PDIS | M3)},	/* UART1_RTSN */
>>   	{I2C1_SDA, (IEN | PTU | PDIS | M0)},	/* I2C1_SDA */
>>   	{I2C1_SCL, (IEN | PTU | PDIS | M0)},	/* I2C1_SCL */
>> +	{GPMC_A13, (IEN | PDIS | M1)},	/* QSPI1_RTCLK */
>> +	{GPMC_A14, (IEN | PDIS | M1)},  /* QSPI1_D[3] */
>> +	{GPMC_A15, (IEN | PDIS | M1)},	/* QSPI1_D[2] */
>> +	{GPMC_A16, (IEN | PDIS | M1)},	/* QSPI1_D[1] */
>> +	{GPMC_A17, (IEN | PDIS | M1)},	/* QSPI1_D[0] */
>> +	{GPMC_A18, (IEN | PDIS | M1)},	/* QSPI1_SCLK */
>> +	{GPMC_A3, (IEN | PDIS | M1)},	/* QSPI1_CS2 */
>> +	{GPMC_A4, (IEN | PDIS | M1)},	/* QSPI1_CS3 */
>> +	{GPMC_CS2, (IEN | PTU | PDIS | M1)},	/* QSPI1_CS0 */
>> +	{GPMC_CS3, (IEN | PTU | PDIS | M1)},	/* QSPI1_CS1*/
Just a nitpick - Could someone audit this to ensure that only input/full 
duplex pins are set to IEN(Input Enable)?
Chip select (CS), SCLK, RTCLK dont seem to be candidates for input to DRA.

---
Regards,
Nishanth Menon

  reply	other threads:[~2013-07-10 23:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 11:25 [U-Boot] [PATCH 0/7] qspi controller: Normal, quad and memory mapped read support Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [PATCH 1/7] omap5: add qspi support Sourav Poddar
2013-07-10 13:23   ` Nishanth Menon
2013-07-10 13:43     ` Tom Rini
2013-07-11  6:19       ` Sourav Poddar
2013-07-11  6:17     ` Sourav Poddar
2013-07-10 13:40   ` Lokesh Vutla
2013-07-11  6:17     ` Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [PATCH 2/7] spi: add TI QSPI driver Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [PATCH 3/7] dra7xx_evm: add SPL API, QSPI, and serial flash support Sourav Poddar
2013-07-10 13:47   ` Lokesh Vutla
2013-07-10 23:58     ` Nishanth Menon [this message]
2013-07-11  6:40       ` Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [RFC/PATCH 4/7] drivers: mtd: spi: Modify read/write command for sfl256s flash Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [RFC/PATCH 5/7] drivers: mtd: qspi: Add quad read support Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [RFC/PATCH 6/7] driver: spi: Add memory mapped " Sourav Poddar
2013-07-10 11:25 ` [U-Boot] [PATCH 7/7] README: qspi usecase and testing documentation Sourav Poddar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DDF53D.1070200@gmail.com \
    --to=menon.nishanth@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.