From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxBuY-0005nR-24 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 04:07:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxBuW-0003tM-Hm for qemu-devel@nongnu.org; Thu, 11 Jul 2013 04:07:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33665 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxBuW-0003tF-7H for qemu-devel@nongnu.org; Thu, 11 Jul 2013 04:07:32 -0400 Message-ID: <51DE67BC.3020803@suse.de> Date: Thu, 11 Jul 2013 10:07:24 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4dacd064382f8e7792bec6547a08492225d85407.1373440128.git.peter.crosthwaite@xilinx.com> In-Reply-To: <4dacd064382f8e7792bec6547a08492225d85407.1373440128.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next v2 1/5] target-arm/cpu.c: delete un-needed instance/class sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com, Peter Maydell Cc: hutao@cn.fujitsu.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com Am 11.07.2013 03:45, schrieb peter.crosthwaite@xilinx.com: > From: Peter Crosthwaite >=20 > QOM automatically inherits class and instance size from the parent > class. No need to redefine as the same value as the parent. Quoting my original comment: "It would be fair to mention since which commit because that was originally not the case." http://git.qemu.org/?p=3Dqemu.git;a=3Dcommit;h=3Daca59af612840772f1859836= 3b65a25bf02bb569 E.g., "By now, QOM automatically..." or "Since commit ..." >=20 > CC: qemu-trivial@nongnu.org We have an active ARM maintainer, so no reason to involve qemu-trivial here by our definition. Possibly that would've required Cc: anyway? Not actually CC'ed. >=20 > Signed-off-by: Peter Crosthwaite Still: Reviewed-by: Andreas F=E4rber PMM, do you want to pick this one up for target-arm.next? The rest depends on central infrastructure under discussion. Suggest renaming to "target-arm: Delete un-needed instance/class sizes for ARMCPU subclasses" for simplicity and so that it aligns nicely with others. Regards, Andreas > --- >=20 > target-arm/cpu.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/target-arm/cpu.c b/target-arm/cpu.c > index 1bc227e..ed53df8 100644 > --- a/target-arm/cpu.c > +++ b/target-arm/cpu.c > @@ -823,9 +823,7 @@ static void cpu_register(const ARMCPUInfo *info) > { > TypeInfo type_info =3D { > .parent =3D TYPE_ARM_CPU, > - .instance_size =3D sizeof(ARMCPU), > .instance_init =3D info->initfn, > - .class_size =3D sizeof(ARMCPUClass), > .class_init =3D info->class_init, > }; > =20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg