diff for duplicates of <51DE6E87.5050201@nvidia.com> diff --git a/a/1.txt b/N1/1.txt index 02459c5..7a05372 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,7 +4,7 @@ On 07/11/2013 02:12 AM, Guenter Roeck wrote: >>> When the temperature exceed the limit range value, >>> the driver can handle the interrupt. >>> ->>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>>> Signed-off-by: Wei Ni <wni@nvidia.com> >>> --- >>> drivers/hwmon/lm90.c | 77 +++++++++++++++++++++++++++++++++++++++++--------- >>> 1 file changed, 64 insertions(+), 13 deletions(-) @@ -100,21 +100,21 @@ Yes, it should be a separate patch, I will do it. >>> + >>> + lm90_read_reg(client, LM90_REG_R_STATUS, &alarms); >>> + ->>> + if (data->kind == max6696) +>>> + if (data->kind = max6696) >>> + lm90_read_reg(client, MAX6696_REG_R_STATUS2, &alarms_max6696); >>> + ->>> + if ((alarms & 0x7f) == 0 && (alarms_max6696 & 0xfe) == 0) { +>>> + if ((alarms & 0x7f) = 0 && (alarms_max6696 & 0xfe) = 0) { >>> + return IRQ_NONE; >> >> For non-MAX6696 chips this will evaluate to: >> ->> if ((alarms & 0x7f) == 0 && (0 & 0xfe) == 0) +>> if ((alarms & 0x7f) = 0 && (0 & 0xfe) = 0) >> >> and therefore be true for any value of "alarms" and therefore always >> result in IRQ_NONE being returned. >> > Not really. If -> (alarms & 0xfe) == 0 +> (alarms & 0xfe) = 0 > returns false (ie thee is an alarm) the expression is false and the > if statement won't be executed. Or maybe I didn't get enough sleep > last night ;). @@ -133,4 +133,10 @@ Yes, it should be a separate patch, I will do it. > >> Thierry > -> +> + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index ccd7fa9..d9cf8d4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,9 +3,9 @@ "ref\020130710170552.GA15665@dhcp-172-17-186-34.nvidia.com\0" "ref\020130710181248.GA22430@roeck-us.net\0" "ref\020130710181248.GA22430-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.\0" - "Date\0Thu, 11 Jul 2013 16:36:23 +0800\0" + "From\0Wei Ni <wni@nvidia.com>\0" + "Subject\0Re: [lm-sensors] [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.\0" + "Date\0Thu, 11 Jul 2013 08:36:23 +0000\0" "To\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" "Cc\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> @@ -21,7 +21,7 @@ ">>> When the temperature exceed the limit range value,\n" ">>> the driver can handle the interrupt.\n" ">>>\n" - ">>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">>> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">>> ---\n" ">>> drivers/hwmon/lm90.c | 77 +++++++++++++++++++++++++++++++++++++++++---------\n" ">>> 1 file changed, 64 insertions(+), 13 deletions(-)\n" @@ -117,21 +117,21 @@ ">>> +\n" ">>> +\tlm90_read_reg(client, LM90_REG_R_STATUS, &alarms);\n" ">>> +\n" - ">>> +\tif (data->kind == max6696)\n" + ">>> +\tif (data->kind = max6696)\n" ">>> +\t\tlm90_read_reg(client, MAX6696_REG_R_STATUS2, &alarms_max6696);\n" ">>> +\n" - ">>> +\tif ((alarms & 0x7f) == 0 && (alarms_max6696 & 0xfe) == 0) {\n" + ">>> +\tif ((alarms & 0x7f) = 0 && (alarms_max6696 & 0xfe) = 0) {\n" ">>> +\t\treturn IRQ_NONE;\n" ">>\n" ">> For non-MAX6696 chips this will evaluate to:\n" ">>\n" - ">> \tif ((alarms & 0x7f) == 0 && (0 & 0xfe) == 0)\n" + ">> \tif ((alarms & 0x7f) = 0 && (0 & 0xfe) = 0)\n" ">>\n" ">> and therefore be true for any value of \"alarms\" and therefore always\n" ">> result in IRQ_NONE being returned.\n" ">>\n" "> Not really. If\n" - "> \t(alarms & 0xfe) == 0\n" + "> \t(alarms & 0xfe) = 0\n" "> returns false (ie thee is an alarm) the expression is false and the\n" "> if statement won't be executed. Or maybe I didn't get enough sleep\n" "> last night ;).\n" @@ -150,6 +150,12 @@ "> \n" ">> Thierry\n" "> \n" - > + "> \n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -4d1d119862c18530e39b1a6cf43f01698c229e01e07df89b8d6edefd7d4f9302 +5b8268c658c109fca30f7936b21b2e31f599081968e95813e5c21dac691b025a
diff --git a/a/1.txt b/N2/1.txt index 02459c5..a6fc517 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,7 +4,7 @@ On 07/11/2013 02:12 AM, Guenter Roeck wrote: >>> When the temperature exceed the limit range value, >>> the driver can handle the interrupt. >>> ->>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>>> Signed-off-by: Wei Ni <wni@nvidia.com> >>> --- >>> drivers/hwmon/lm90.c | 77 +++++++++++++++++++++++++++++++++++++++++--------- >>> 1 file changed, 64 insertions(+), 13 deletions(-) diff --git a/a/content_digest b/N2/content_digest index ccd7fa9..08d6b6c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,17 +2,16 @@ "ref\01373455539-2831-3-git-send-email-wni@nvidia.com\0" "ref\020130710170552.GA15665@dhcp-172-17-186-34.nvidia.com\0" "ref\020130710181248.GA22430@roeck-us.net\0" - "ref\020130710181248.GA22430-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" + "From\0Wei Ni <wni@nvidia.com>\0" "Subject\0Re: [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.\0" "Date\0Thu, 11 Jul 2013 16:36:23 +0800\0" - "To\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" - "Cc\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" - khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> - swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Guenter Roeck <linux@roeck-us.net>\0" + "Cc\0Thierry Reding <thierry.reding@gmail.com>" + khali@linux-fr.org <khali@linux-fr.org> + swarren@wwwdotorg.org <swarren@wwwdotorg.org> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-tegra@vger.kernel.org <linux-tegra@vger.kernel.org>\0" "\00:1\0" "b\0" "On 07/11/2013 02:12 AM, Guenter Roeck wrote:\n" @@ -21,7 +20,7 @@ ">>> When the temperature exceed the limit range value,\n" ">>> the driver can handle the interrupt.\n" ">>>\n" - ">>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">>> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">>> ---\n" ">>> drivers/hwmon/lm90.c | 77 +++++++++++++++++++++++++++++++++++++++++---------\n" ">>> 1 file changed, 64 insertions(+), 13 deletions(-)\n" @@ -152,4 +151,4 @@ "> \n" > -4d1d119862c18530e39b1a6cf43f01698c229e01e07df89b8d6edefd7d4f9302 +145c5bc6e81f68ec16c0cc809d55e2e6de29dbc2a9958aa60c796ef66106ae2f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.