diff for duplicates of <51DE6FD9.8080206@nvidia.com> diff --git a/a/1.txt b/N1/1.txt index 7a5bf42..781ccbc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ On 07/11/2013 02:21 AM, Guenter Roeck wrote: >> Split set&show temp codes as common functions, so we can use it directly when >> implement linux thermal framework. >> ->> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 75 insertions(+), 43 deletions(-) @@ -30,10 +30,10 @@ On 07/11/2013 02:21 AM, Guenter Roeck wrote: Oh, I didn't noticed it yet, thanks for your review, I will change it. > ->> if (data->kind == adt7461) +>> if (data->kind = adt7461) >> - temp = temp_from_u8_adt7461(data, data->temp8[attr->index]); >> + temp = temp_from_u8_adt7461(data, data->temp8[index]); ->> else if (data->kind == max6646) +>> else if (data->kind = max6646) >> - temp = temp_from_u8(data->temp8[attr->index]); >> + temp = temp_from_u8(data->temp8[index]); >> else @@ -41,8 +41,8 @@ Oh, I didn't noticed it yet, thanks for your review, I will change it. >> + temp = temp_from_s8(data->temp8[index]); >> >> /* +16 degrees offset for temp2 for the LM99 */ ->> - if (data->kind == lm99 && attr->index == 3) ->> + if (data->kind == lm99 && index == 3) +>> - if (data->kind = lm99 && attr->index = 3) +>> + if (data->kind = lm99 && index = 3) >> temp += 16000; >> >> + return temp; @@ -88,15 +88,15 @@ Ok, I will update it. >> - return err; >> >> /* +16 degrees offset for temp2 for the LM99 */ ->> - if (data->kind == lm99 && attr->index == 3) ->> + if (data->kind == lm99 && index == 3) +>> - if (data->kind = lm99 && attr->index = 3) +>> + if (data->kind = lm99 && index = 3) >> val -= 16000; >> >> mutex_lock(&data->update_lock); ->> if (data->kind == adt7461) +>> if (data->kind = adt7461) >> - data->temp8[nr] = temp_to_u8_adt7461(data, val); >> + data->temp8[index] = temp_to_u8_adt7461(data, val); ->> else if (data->kind == max6646) +>> else if (data->kind = max6646) >> - data->temp8[nr] = temp_to_u8(val); >> + data->temp8[index] = temp_to_u8(val); >> else @@ -140,10 +140,10 @@ Ok, I will update it. >> > Another unnecessary variable reorder. > ->> if (data->kind == adt7461) +>> if (data->kind = adt7461) >> - temp = temp_from_u16_adt7461(data, data->temp11[attr->index]); >> + temp = temp_from_u16_adt7461(data, data->temp11[index]); ->> else if (data->kind == max6646) +>> else if (data->kind = max6646) >> - temp = temp_from_u16(data->temp11[attr->index]); >> + temp = temp_from_u16(data->temp11[index]); >> else @@ -151,8 +151,8 @@ Ok, I will update it. >> + temp = temp_from_s16(data->temp11[index]); >> >> /* +16 degrees offset for temp2 for the LM99 */ ->> - if (data->kind == lm99 && attr->index <= 2) ->> + if (data->kind == lm99 && index <= 2) +>> - if (data->kind = lm99 && attr->index <= 2) +>> + if (data->kind = lm99 && index <= 2) >> temp += 16000; >> >> + return temp; @@ -195,7 +195,7 @@ Ok, I will update it. >> - return err; >> >> /* +16 degrees offset for temp2 for the LM99 */ ->> if (data->kind == lm99 && index <= 2) +>> if (data->kind = lm99 && index <= 2) >> @@ -839,6 +854,23 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr, >> lm90_select_remote_channel(client, data, 0); >> @@ -224,3 +224,9 @@ Ok, I will update it. >> 1.7.9.5 >> >> + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 496a676..535d692 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,9 +2,9 @@ "ref\01373455539-2831-2-git-send-email-wni@nvidia.com\0" "ref\020130710182154.GC22430@roeck-us.net\0" "ref\020130710182154.GC22430-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes\0" - "Date\0Thu, 11 Jul 2013 16:42:01 +0800\0" + "From\0Wei Ni <wni@nvidia.com>\0" + "Subject\0Re: [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes\0" + "Date\0Thu, 11 Jul 2013 08:42:01 +0000\0" "To\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> @@ -19,7 +19,7 @@ ">> Split set&show temp codes as common functions, so we can use it directly when\n" ">> implement linux thermal framework.\n" ">>\n" - ">> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">> ---\n" ">> drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------\n" ">> 1 file changed, 75 insertions(+), 43 deletions(-)\n" @@ -46,10 +46,10 @@ "Oh, I didn't noticed it yet, thanks for your review, I will change it.\n" "\n" "> \n" - ">> if (data->kind == adt7461)\n" + ">> if (data->kind = adt7461)\n" ">> - temp = temp_from_u8_adt7461(data, data->temp8[attr->index]);\n" ">> + temp = temp_from_u8_adt7461(data, data->temp8[index]);\n" - ">> else if (data->kind == max6646)\n" + ">> else if (data->kind = max6646)\n" ">> - temp = temp_from_u8(data->temp8[attr->index]);\n" ">> + temp = temp_from_u8(data->temp8[index]);\n" ">> else\n" @@ -57,8 +57,8 @@ ">> + temp = temp_from_s8(data->temp8[index]);\n" ">>\n" ">> /* +16 degrees offset for temp2 for the LM99 */\n" - ">> - if (data->kind == lm99 && attr->index == 3)\n" - ">> + if (data->kind == lm99 && index == 3)\n" + ">> - if (data->kind = lm99 && attr->index = 3)\n" + ">> + if (data->kind = lm99 && index = 3)\n" ">> temp += 16000;\n" ">>\n" ">> + return temp;\n" @@ -104,15 +104,15 @@ ">> - return err;\n" ">>\n" ">> /* +16 degrees offset for temp2 for the LM99 */\n" - ">> - if (data->kind == lm99 && attr->index == 3)\n" - ">> + if (data->kind == lm99 && index == 3)\n" + ">> - if (data->kind = lm99 && attr->index = 3)\n" + ">> + if (data->kind = lm99 && index = 3)\n" ">> val -= 16000;\n" ">>\n" ">> mutex_lock(&data->update_lock);\n" - ">> if (data->kind == adt7461)\n" + ">> if (data->kind = adt7461)\n" ">> - data->temp8[nr] = temp_to_u8_adt7461(data, val);\n" ">> + data->temp8[index] = temp_to_u8_adt7461(data, val);\n" - ">> else if (data->kind == max6646)\n" + ">> else if (data->kind = max6646)\n" ">> - data->temp8[nr] = temp_to_u8(val);\n" ">> + data->temp8[index] = temp_to_u8(val);\n" ">> else\n" @@ -156,10 +156,10 @@ ">>\n" "> Another unnecessary variable reorder.\n" "> \n" - ">> if (data->kind == adt7461)\n" + ">> if (data->kind = adt7461)\n" ">> - temp = temp_from_u16_adt7461(data, data->temp11[attr->index]);\n" ">> + temp = temp_from_u16_adt7461(data, data->temp11[index]);\n" - ">> else if (data->kind == max6646)\n" + ">> else if (data->kind = max6646)\n" ">> - temp = temp_from_u16(data->temp11[attr->index]);\n" ">> + temp = temp_from_u16(data->temp11[index]);\n" ">> else\n" @@ -167,8 +167,8 @@ ">> + temp = temp_from_s16(data->temp11[index]);\n" ">>\n" ">> /* +16 degrees offset for temp2 for the LM99 */\n" - ">> - if (data->kind == lm99 && attr->index <= 2)\n" - ">> + if (data->kind == lm99 && index <= 2)\n" + ">> - if (data->kind = lm99 && attr->index <= 2)\n" + ">> + if (data->kind = lm99 && index <= 2)\n" ">> temp += 16000;\n" ">>\n" ">> + return temp;\n" @@ -211,7 +211,7 @@ ">> - return err;\n" ">>\n" ">> /* +16 degrees offset for temp2 for the LM99 */\n" - ">> if (data->kind == lm99 && index <= 2)\n" + ">> if (data->kind = lm99 && index <= 2)\n" ">> @@ -839,6 +854,23 @@ static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,\n" ">> lm90_select_remote_channel(client, data, 0);\n" ">>\n" @@ -239,6 +239,12 @@ ">> --\n" ">> 1.7.9.5\n" ">>\n" - >> + ">>\n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -e44f8634ab01c73de78d25ac4fb967ab71bcb0ea93b32e4a360e62a74e362c38 +87a41515c0092408c3efe9e44e3f7ac63f38053c49213264362f368eaa167ca1
diff --git a/a/1.txt b/N2/1.txt index 7a5bf42..e7d6c08 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,7 +3,7 @@ On 07/11/2013 02:21 AM, Guenter Roeck wrote: >> Split set&show temp codes as common functions, so we can use it directly when >> implement linux thermal framework. >> ->> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 75 insertions(+), 43 deletions(-) diff --git a/a/content_digest b/N2/content_digest index 496a676..512a962 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,17 +1,16 @@ "ref\01373455539-2831-1-git-send-email-wni@nvidia.com\0" "ref\01373455539-2831-2-git-send-email-wni@nvidia.com\0" "ref\020130710182154.GC22430@roeck-us.net\0" - "ref\020130710182154.GC22430-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" + "From\0Wei Ni <wni@nvidia.com>\0" "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes\0" "Date\0Thu, 11 Jul 2013 16:42:01 +0800\0" - "To\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" - "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" - swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Guenter Roeck <linux@roeck-us.net>\0" + "Cc\0khali@linux-fr.org <khali@linux-fr.org>" + swarren@wwwdotorg.org <swarren@wwwdotorg.org> + thierry.reding@gmail.com <thierry.reding@gmail.com> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-tegra@vger.kernel.org <linux-tegra@vger.kernel.org>\0" "\00:1\0" "b\0" "On 07/11/2013 02:21 AM, Guenter Roeck wrote:\n" @@ -19,7 +18,7 @@ ">> Split set&show temp codes as common functions, so we can use it directly when\n" ">> implement linux thermal framework.\n" ">>\n" - ">> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">> ---\n" ">> drivers/hwmon/lm90.c | 118 ++++++++++++++++++++++++++++++++------------------\n" ">> 1 file changed, 75 insertions(+), 43 deletions(-)\n" @@ -241,4 +240,4 @@ ">>\n" >> -e44f8634ab01c73de78d25ac4fb967ab71bcb0ea93b32e4a360e62a74e362c38 +fc088f216c3e1a56fa573accb5ae2ffe2788facdf2460452cb585a4781121ebf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.