All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH 2/6] ASoC: omap-pcm: Request the DMA channel by name when dma_name is set for the dai
Date: Thu, 11 Jul 2013 14:30:18 +0200	[thread overview]
Message-ID: <51DEA55A.2060301@ti.com> (raw)
In-Reply-To: <51DE9369.7090703@metafoo.de>

On 07/11/2013 01:13 PM, Lars-Peter Clausen wrote:
> I'd prefer not having to have to add a field for a OMAP specific hack to the
> generic struct.

I thought that it might be usable for others later, but yeah. It is OMAP
specific right now.

> Two options which are  in my opinion better:
> 
> 1) Just use filter_data in both cases and check rtd->cpu_dai->dev.of_node to
> see whether to use it as the name to dma_request_slave_channel or as
> filter_data for snd_dmaengine_pcm_open_request_chan.

I'll stick with this one since I do not want to create a header file just for
the omap_pcm_filter_data...
I'll send the v2 in a couple of minutes (I have already tested it).

Thanks,
Péter

  reply	other threads:[~2013-07-11 12:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 10:18 [PATCH 0/6] ASoC: Regression fix for OMAP in DT boot (3.11) Peter Ujfalusi
2013-07-11 10:18 ` [PATCH 1/6] ASoC: dmaengine_pcm: Add dma_name to snd_dmaengine_dai_dma_data Peter Ujfalusi
2013-07-11 10:18 ` [PATCH 2/6] ASoC: omap-pcm: Request the DMA channel by name when dma_name is set for the dai Peter Ujfalusi
2013-07-11 11:13   ` Lars-Peter Clausen
2013-07-11 12:30     ` Peter Ujfalusi [this message]
2013-07-11 10:18 ` [PATCH 3/6] ASoC: omap-mcpdm: Do not use platform_get_resource_byname() for DMA Peter Ujfalusi
2013-07-11 10:18 ` [PATCH 4/6] ASoC: omap-dmic: " Peter Ujfalusi
2013-07-11 10:18 ` [PATCH 5/6] ASoC: omap-mcbsp: Use different method for DMA request when booted with DT Peter Ujfalusi
2013-07-11 10:18 ` [PATCH 6/6] ASoC: omap-dmic: Cleanup the probe function Peter Ujfalusi
2013-07-11 11:10   ` Lars-Peter Clausen
2013-07-11 12:31     ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DEA55A.2060301@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.