From: Fuxin Zhang <zhangfx@lemote.com>
To: Huacai Chen <chenhc@lemote.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
John Crispin <john@phrozen.org>,
linux-mips@linux-mips.org, Zhangjin Wu <wuzhangjin@gmail.com>,
Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
Subject: Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support
Date: Thu, 11 Jul 2013 20:35:19 +0800 [thread overview]
Message-ID: <51DEA687.6040208@lemote.com> (raw)
In-Reply-To: <CAAhV-H4m5c++fFTtr9kd294MXtRH-DwTMmXP2Ds7w+6S==jorw@mail.gmail.com>
于 2013/7/11 17:31, Huacai Chen 写道:
> Normal labels and nops can be removed, but loongson3_play_dead()
> should be run at CKSEG0, I'm afraid that it will have a wrong behavior
> if I write it with C.
I think just replacing flush_loop with number label like 1: will be ok.
Don't think too much.
>
> On Fri, Jun 28, 2013 at 3:08 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
>> On Fri, Jun 28, 2013 at 09:05:53AM +0200, Ralf Baechle wrote:
>>
>>>> + "flush_loop: \n" /* flush L1 */
>>> Please don't use normale in inline assembler. This might result in build
>>> errors. it's horrible to read but number local labels like:
>> That was meant to read "Please don't use normal labels" in inline assembler.
>>
>> Ralf
>>
--
江苏中科梦兰电子科技有限公司
总经理 张福新
zhangfx@lemote.com
next prev parent reply other threads:[~2013-07-11 12:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 12:46 [PATCH V10 00/13] MIPS: Add Loongson-3 based machines support Huacai Chen
2013-04-15 12:46 ` [PATCH V10 01/13] MIPS: Loongson: Add basic Loongson-3 definition Huacai Chen
2013-06-22 12:48 ` Andreas Barth
2013-04-15 12:46 ` [PATCH V10 02/13] MIPS: Loongson: Add basic Loongson-3 CPU support Huacai Chen
2013-04-15 12:46 ` [PATCH V10 03/13] MIPS: Loongson: Introduce and use cpu_has_coherent_cache feature Huacai Chen
2013-04-15 12:46 ` [PATCH V10 04/13] MIPS: Loongson 3: Add Lemote-3A machtypes definition Huacai Chen
2013-04-15 12:47 ` [PATCH V10 05/13] MIPS: Loongson: Add UEFI-like firmware interface support Huacai Chen
2013-06-22 12:59 ` Andreas Barth
2013-06-23 2:02 ` chenhc
2013-04-15 12:47 ` [PATCH V10 06/13] MIPS: Loongson 3: Add HT-linked PCI support Huacai Chen
2013-06-22 13:09 ` Andreas Barth
2013-06-23 2:05 ` chenhc
2013-04-15 12:47 ` [PATCH V10 07/13] MIPS: Loongson 3: Add IRQ init and dispatch support Huacai Chen
2013-04-15 12:47 ` [PATCH V10 08/13] MIPS: Loongson 3: Add serial port support Huacai Chen
2013-04-15 12:47 ` [PATCH V10 09/13] MIPS: Loongson: Add swiotlb to support big memory (>4GB) Huacai Chen
2013-04-15 12:47 ` [PATCH V10 10/13] MIPS: Loongson: Add Loongson-3 Kconfig options Huacai Chen
2013-04-15 12:47 ` [PATCH V10 11/13] MIPS: Loongson 3: Add Loongson-3 SMP support Huacai Chen
2013-04-15 12:47 ` [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support Huacai Chen
2013-06-28 7:05 ` Ralf Baechle
2013-06-28 7:08 ` Ralf Baechle
2013-07-11 9:31 ` Huacai Chen
2013-07-11 12:35 ` Fuxin Zhang [this message]
2013-04-15 12:47 ` [PATCH V10 13/13] MIPS: Loongson: Add a Loongson-3 default config file Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DEA687.6040208@lemote.com \
--to=zhangfx@lemote.com \
--cc=chenhc@lemote.com \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=taohl@lemote.com \
--cc=wuzhangjin@gmail.com \
--cc=yanh@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.