From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH v2 0/4] ASoC: Regression fix for OMAP in DT boot (3.11)
Date: Thu, 11 Jul 2013 16:02:10 +0200 [thread overview]
Message-ID: <51DEBAE2.6060709@metafoo.de> (raw)
In-Reply-To: <1373546146-30271-1-git-send-email-peter.ujfalusi@ti.com>
On 07/11/2013 02:35 PM, Peter Ujfalusi wrote:
> Hi,
>
> Changes since v1:
> - Drop the change in dmaengine_pcm.h
> - Use .filter_data to store the DMA channel name
> - omap-pcm: checks if the DAI is probed via DT and uses decides which method to
> use to request the DMA channel
> - Dropped the cleanup patch for omap-dmic from the series
> I will send another series with cleanups later
>
> I just noticed in mainline kernel (pre 3.11-rc1) that OMAP4 audio is not probing
> anymore. This is because OMAP4 also moved to DT only mode (3.10 DT boot was
> fine).
> The issue underneath is that we can not use platform_get_resource_byname() for
> DMA resources when booted with devicetree.
>
> In case of DT boot we can use the DMA name to request the channel.
>
> Due to technical issues OMAP can not be moved to generic dmaengine pcm as other
> SoCs did.
>
> Mark: can you queue this series for 3.11? Thank you.
>
> Regards,
> Peter
Looks good, all 4 patches:
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
But I'm wondering who do you register the PCM device in the DT case? Do you
have a separate DT node for the PCM device?
- Lars
> ---
> Peter Ujfalusi (4):
> ASoC: omap-pcm: Request the DMA channel differently when DT is
> involved
> ASoC: omap-mcpdm: Do not use platform_get_resource_byname() for DMA
> ASoC: omap-dmic: Do not use platform_get_resource_byname() for DMA
> ASoC: omap-mcbsp: Use different method for DMA request when booted
> with DT
>
> sound/soc/omap/mcbsp.c | 39 ++++++++++++++++++++++-----------------
> sound/soc/omap/omap-dmic.c | 11 +----------
> sound/soc/omap/omap-mcpdm.c | 16 ++--------------
> sound/soc/omap/omap-pcm.c | 17 ++++++++++++++---
> 4 files changed, 39 insertions(+), 44 deletions(-)
>
next prev parent reply other threads:[~2013-07-11 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:35 [PATCH v2 0/4] ASoC: Regression fix for OMAP in DT boot (3.11) Peter Ujfalusi
2013-07-11 12:35 ` [PATCH v2 1/4] ASoC: omap-pcm: Request the DMA channel differently when DT is involved Peter Ujfalusi
2013-07-11 16:38 ` Mark Brown
2013-07-11 12:35 ` [PATCH v2 2/4] ASoC: omap-mcpdm: Do not use platform_get_resource_byname() for DMA Peter Ujfalusi
2013-07-11 12:35 ` [PATCH v2 3/4] ASoC: omap-dmic: " Peter Ujfalusi
2013-07-11 12:35 ` [PATCH v2 4/4] ASoC: omap-mcbsp: Use different method for DMA request when booted with DT Peter Ujfalusi
2013-07-11 14:02 ` Lars-Peter Clausen [this message]
2013-07-11 14:23 ` [PATCH v2 0/4] ASoC: Regression fix for OMAP in DT boot (3.11) Peter Ujfalusi
2013-07-11 16:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DEBAE2.6060709@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.