From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH v2 5/9] cgroup: update error handling in cgroup_populate_dir() Date: Fri, 12 Jul 2013 14:07:08 +0800 Message-ID: <51DF9D0C.30304@huawei.com> References: <1372463145-4245-1-git-send-email-tj@kernel.org> <1372463145-4245-6-git-send-email-tj@kernel.org> <20130711171825.GD10195@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130711171825.GD10195-9pTldWuhBndy/B6EtB590w@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On 2013/7/12 1:18, Tejun Heo wrote: >>>From 4b5e65e0911690422a9b253b8ef68b14288e99c5 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Fri, 28 Jun 2013 16:24:11 -0700 > > cgroup_populate_dir() didn't use to check whether the actual file > creations were successful and could return success with only subset of > the requested files created, which is nasty. > > This patch udpates cgroup_populate_dir() so that it either succeeds > with all files or fails with no file. > > v2: The original patch also converted for_each_root_subsys() usages to > for_each_subsys() without explaining why. That part has been > moved to a separate patch. > > Signed-off-by: Tejun Heo Acked-by: Li Zefan