From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call
Date: Fri, 12 Jul 2013 09:27:21 +0200 [thread overview]
Message-ID: <51DFAFD9.1010805@denx.de> (raw)
In-Reply-To: <1373556206-29238-1-git-send-email-marex@denx.de>
On 11/07/2013 17:23, Marek Vasut wrote:
> Remove incorrectly called and duplicate flush_dcache_range() call
> from fec_mxc driver. The call is not needed, since the caches are
> already flushed in fec_tbd_init(), moreover the second argument should
> be the ending address, not size.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reported-by: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
> ---
> drivers/net/fec_mxc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index da95e28..97bf8fe 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
> }
> memset(fec->tbd_base, 0, size);
> fec_tbd_init(fec);
> - flush_dcache_range((unsigned)fec->tbd_base, size);
> }
>
> /*
>
Applied to u-boot-imx (fix), thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2013-07-12 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 15:23 [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call Marek Vasut
2013-07-12 7:27 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DFAFD9.1010805@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.