From: Peter Hurley <peter@hurleysoftware.com>
To: Gianluca Anzolin <gianluca@sottospazio.it>
Cc: Gustavo Padovan <gustavo@padovan.org>,
linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH v2] Fix refcounting issues in rfcomm/tty.c
Date: Fri, 12 Jul 2013 11:06:31 -0400 [thread overview]
Message-ID: <51E01B77.5080206@hurleysoftware.com> (raw)
In-Reply-To: <20130712101852.GB2065@joana>
On 07/12/2013 06:18 AM, Gustavo Padovan wrote:
> Hi Gianluca,
>
> * Gianluca Anzolin <gianluca@sottospazio.it> [2013-07-11 21:01:50 +0200]:
>
>> Hello,
>>
>> This is a second version of the previous patches I sent to linux-bluetooth
>> list. I grouped the two patches together since they are related.
>>
>> I fixed some bugs in my previous attempt:
>
> If you are fixing different bugs I want one patch for each fix.
>
>> 1. skb_queue_purge is now called in the cleanup method to avoid a circular
>> dependency between the dev struct and dlc struct.
>>
>> 2. refcomm_dev_release should check REFCOMM_TTY_RELEASED instead of
>> REFCOMM_RELEASE_ONHUP.
>>
>> I checked with both bluez4 and bluez5 and everything works as expected.
>
> Please send a proper inline patch with git-format-patch and git-send-email. Also
> get rid of all BT_DBG changes you've made, read the dynamic debug doc to learn
> how to print the function name when debugging. And if you are moving functions around
> please do this in a separated patch.
Please cc me on this series when these changes are split up and
I'll be happy to review it.
Regards,
Peter Hurley
prev parent reply other threads:[~2013-07-12 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 19:01 [PATCH v2] Fix refcounting issues in rfcomm/tty.c Gianluca Anzolin
2013-07-12 10:18 ` Gustavo Padovan
2013-07-12 15:06 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E01B77.5080206@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gianluca@sottospazio.it \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.