From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxgqy-0007RO-8E for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:09:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uxgqx-0003pY-5W for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:09:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxgqw-0003pD-Eq for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:09:55 -0400 Message-ID: <51E0385C.1000805@redhat.com> Date: Fri, 12 Jul 2013 11:09:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373640028-5138-1-git-send-email-mrhines@linux.vnet.ibm.com> <1373640028-5138-3-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1373640028-5138-3-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2KCBRPTBCDKQWVAQXGGIJ" Subject: Re: [Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control_save_page() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2KCBRPTBCDKQWVAQXGGIJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/12/2013 08:40 AM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > We were not checking for a valid 'bytes_sent' pointer before accessing = it. >=20 > Signed-off-by: Michael R. Hines > --- > savevm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/savevm.c b/savevm.c > index e0491e7..03fc4d9 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -662,7 +662,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_= t block_offset, > offset, size, bytes_sent); > =20 > if (ret !=3D RAM_SAVE_CONTROL_DELAYED) { > - if (*bytes_sent > 0) { > + if (bytes_sent && *bytes_sent > 0) { > qemu_update_position(f, *bytes_sent); > } else if (ret < 0) { > qemu_file_set_error(f, ret); >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2KCBRPTBCDKQWVAQXGGIJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR4DhcAAoJEKeha0olJ0NqNT4IAISZ7hYMqzlBnJG3jqUYAi7q Bn7R4WvVW6jVZKM20OOYtfo4Po8ZvQaMtJBsh5CHy+3TS2bitB0umbbAkbGYUPA7 foHmwA1Pzc/kaBao39EJAhT0uWDbTTfLfuXFmh+05cCP3WVPDNhr8JurNVH1Q3tL C0CTJ3k93Wl1NpTouv/7GBE0xKndSOb2QPe10ZbbtKoKk9iwknoD3lgfoBb+63eW ol9WjzrBANSpmOc74nGLDAXfRr8PwyVqDr8LAk3WujrRlBqx/+vLBVitkCUJ9s7x eH9pR2hPfooWefpd43DD01TCijk7RRcbjApveiygXM8uBNZ7HnDnuQ6MzCgOZek= =z94f -----END PGP SIGNATURE----- ------enig2KCBRPTBCDKQWVAQXGGIJ--