From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxhJc-0005ug-B2 for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxhJb-0007pP-7x for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:39:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxhJb-0007pB-0d for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:39:31 -0400 Message-ID: <51E03F4C.9040506@redhat.com> Date: Fri, 12 Jul 2013 11:39:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373640028-5138-1-git-send-email-mrhines@linux.vnet.ibm.com> <1373640028-5138-2-git-send-email-mrhines@linux.vnet.ibm.com> <51E0382E.5030209@redhat.com> <51E03C2D.9020206@linux.vnet.ibm.com> In-Reply-To: <51E03C2D.9020206@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2WHDMVGKOXVMJEXCSBSOF" Subject: Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WHDMVGKOXVMJEXCSBSOF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/12/2013 11:26 AM, Michael R. Hines wrote: > On 07/12/2013 01:09 PM, Eric Blake wrote: >> On 07/12/2013 08:40 AM, mrhines@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> As requested, the protocol now includes memory unpinning support. >>> This has been implemented in a non-optimized manner, in such a way >>> that one could devise an LRU or other workload-specific information >>> on top of the basic mechanism to influence the way unpinning happens >>> during runtime. >>> >>> ++++++++++++++++++++++++++++++--------------------- >>> 1 file changed, 30 insertions(+), 21 deletions(-) >> I suggest splitting this patch into two; and cc-ing the first of the t= wo >> patches through qemu-trivial (since formatting cleanups can be applied= >> now, even while still waiting for a comprehensive review of the >> algorithm in the rest of the series) >=20 > My understanding is that the reviews have completed already, > including a very extensive test series that I performed which > included both virt-test results and non-virt-test results from both > myself and Chegu. >=20 > Am I mistaken? It may have been reviewed and tested, but as you just barely posted v3 today and there is not yet a maintainer's queue with a PULL request, it is still subject to any further review that people want to provide, and up to the maintainer to state definitively if the further review comments must be addressed. It's not the end of the world if you don't split this patch, but at the same time, splitting it makes it easier to review, and to pick and choose which parts get backported (trivial formatting vs. new feature). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2WHDMVGKOXVMJEXCSBSOF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR4D9NAAoJEKeha0olJ0Nqs7IH/0Xb/QIQDgoAGfhpHqs6yBcC hjkJK9FQA3WbKzc0QMeHR7OyKNx92XKE8U0fML7QzdgWHCeTkYoumsHppRBdorZo WeWKI9sC2C/NwFlp+x2SpXDf7HItSxqQuRiTpkGSb92v3VbDS9fLdR/Hw6Xpo3Bj fh0203s4u9w08jJPUncz1adJJOUWSeoAOnU3lEbGWnAFn62Mvh2+4yXwpTq45vts mCu01+DSAKQZfepr0cUDBUGD3NK2/WHGhPit83tWt3WJe8/c3d/N/P//2FVNhgbY w3aVrI7iwwqKeergPHRyiwCtoVk1utu9StZxkM89sZ50n0zyuQBuLO8F7epMg+U= =O2Jn -----END PGP SIGNATURE----- ------enig2WHDMVGKOXVMJEXCSBSOF--