From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxhQL-0007ZH-PG for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:46:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxhQJ-0002Hy-Bu for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:46:29 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:58924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxhQJ-0002Hq-4f for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:46:27 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Jul 2013 11:46:26 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 41B6F38C803B for ; Fri, 12 Jul 2013 13:46:21 -0400 (EDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6CHkLgd330488 for ; Fri, 12 Jul 2013 13:46:22 -0400 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6CHkGT2021956 for ; Fri, 12 Jul 2013 11:46:17 -0600 Message-ID: <51E040DC.6040500@linux.vnet.ibm.com> Date: Fri, 12 Jul 2013 13:46:04 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1373640028-5138-1-git-send-email-mrhines@linux.vnet.ibm.com> <1373640028-5138-2-git-send-email-mrhines@linux.vnet.ibm.com> <51E0382E.5030209@redhat.com> <51E03C2D.9020206@linux.vnet.ibm.com> <51E03F4C.9040506@redhat.com> In-Reply-To: <51E03F4C.9040506@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com On 07/12/2013 01:39 PM, Eric Blake wrote: > On 07/12/2013 11:26 AM, Michael R. Hines wrote: >> On 07/12/2013 01:09 PM, Eric Blake wrote: >>> On 07/12/2013 08:40 AM, mrhines@linux.vnet.ibm.com wrote: >>>> From: "Michael R. Hines" >>>> >>>> As requested, the protocol now includes memory unpinning support. >>>> This has been implemented in a non-optimized manner, in such a way >>>> that one could devise an LRU or other workload-specific information >>>> on top of the basic mechanism to influence the way unpinning happens >>>> during runtime. >>>> >>>> ++++++++++++++++++++++++++++++--------------------- >>>> 1 file changed, 30 insertions(+), 21 deletions(-) >>> I suggest splitting this patch into two; and cc-ing the first of the two >>> patches through qemu-trivial (since formatting cleanups can be applied >>> now, even while still waiting for a comprehensive review of the >>> algorithm in the rest of the series) >> My understanding is that the reviews have completed already, >> including a very extensive test series that I performed which >> included both virt-test results and non-virt-test results from both >> myself and Chegu. >> >> Am I mistaken? > It may have been reviewed and tested, but as you just barely posted v3 > today and there is not yet a maintainer's queue with a PULL request, it > is still subject to any further review that people want to provide, and > up to the maintainer to state definitively if the further review > comments must be addressed. It's not the end of the world if you don't > split this patch, but at the same time, splitting it makes it easier to > review, and to pick and choose which parts get backported (trivial > formatting vs. new feature). > Alright - I'll wait until next week before re-sending again. No big deal. Juan? Ping? - Michael