From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJy-0000la-Ev for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyfJt-0002zP-Uu for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:54 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:62461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJt-0002yR-Lt for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:49 -0400 Message-ID: <51E3C43F.6070503@huawei.com> Date: Mon, 15 Jul 2013 11:43:27 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <51DD7454.4020204@huawei.com> In-Reply-To: <51DD7454.4020204@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 0/1] ARM aarch64 TCG tlb fast lookup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jani Kokkonen Cc: Peter Maydell , "qemu-devel@nongnu.org" , Richard Henderson On 10.07.2013 16:48, Jani Kokkonen wrote: > > This patch implements the TCG tlb fast lookup in > tcg_out_qemu_ld/st for the aarch64 TCG target. > Supports also CONFIG_QEMU_LDST_OPTIMIZATION. > > Tested running on a x86-64 physical machine running Foundation v8, > running a linux 3.2.0 minimal host system based on linaro v8 > image build 0.8.4423 for user space. > > Tested guests: arm v5, PPC64, sparc, i386 linux test images. > Also tested on x86-64/linux built with buildroot. > > Changes in v2: > -Fix whitespace and indentation > -Pass mem_index into tcg_out_tlb_read() and calculate tlb_offset inside > tcg_out_tlb_read() > -Add comments in tcg_out_tlb_read() > -Change parameter type from int to TCGREg for data_reg and addr_reg parameters > in add_qemu_ldst_label() > -Use extended register for tcg_out_cmp() in tcg_out_tlb_read() only if needed > > > Jani Kokkonen (1): > tcg/aarch64: Implement tlb lookup fast path > > configure | 2 +- > include/exec/exec-all.h | 14 +++ > tcg/aarch64/tcg-target.c | 224 +++++++++++++++++++++++++++++++++++----------- > 3 files changed, 189 insertions(+), 51 deletions(-) > It's good for me, thank you Jani. Reviewed-by: Claudio Fontana