Re: [PATCH 00/11] Enable PSR on Haswell.

[Shobhit Kumar <shobhit.kumar@intel.com>]

On Friday 12 July 2013 03:14 AM, Rodrigo Vivi wrote:
> I'm resending full series again because after accepting most of suggestions
> and rebasing again on drm-intel-nightly most of patches got some kind of
> conflict so the full series is here again.
>
> First 3 patches on this series are already reviewed and I'd be glad if they
> were merged asap to avoid future conflicts. This patches at least allows
> people to know if they have psr panel or not.
>
> For the rest I accepted most of suggestions and explained on previous emails
> the ones I didn't accepted and why. However even the ones I didn't accepted
> I tested and verified that they caused some kind of issue.
>
> This version is working very fine for a long time in my machine. I'd appreciate if you could merge everything since now psr is disabled by default by kernel flag. So I'm 100% sure that this series won't cause any kind of regression for any user.
>
> I understand that it would be good to deliver psr enabled by default however I'm changing this default behaviour because I'm sure that PSR will cause regression without userspace (DDX) help when using kde and xdm.
>
> Thanks in advance,
> Rodrigo.
>
> Rodrigo Vivi (9):
>    drm/i915: split aux_clock_divider logic in a separated function for
>      reuse.
>    drm/i915: Enable/Disable PSR
>    drm/i915: Added debugfs support for PSR Status
>    drm/i915: Match all PSR mode entry conditions before enabling it.
>    drm/i915: add update function to disable/enable-back PSR
>    drm/intel: add enable_psr module option and disable psr by default
>    drm/i915: Adding global I915_PARAM for PSR ENABLED.
>    drm/i915: Add functions to force psr exit
>    drm/i915: Hook PSR functionality
>
> Shobhit Kumar (2):
>    drm: Added SDP and VSC structures for handling PSR for eDP
>    drm/i915: Read the EDP DPCD and PSR Capability
>
>   drivers/gpu/drm/i915/i915_debugfs.c  | 128 ++++++++++++
>   drivers/gpu/drm/i915/i915_dma.c      |   3 +
>   drivers/gpu/drm/i915/i915_drv.c      |   4 +
>   drivers/gpu/drm/i915/i915_drv.h      |  15 ++
>   drivers/gpu/drm/i915/i915_gem.c      |   2 +
>   drivers/gpu/drm/i915/i915_reg.h      |  74 +++++++
>   drivers/gpu/drm/i915/intel_ddi.c     |   2 +
>   drivers/gpu/drm/i915/intel_display.c |   1 +
>   drivers/gpu/drm/i915/intel_dp.c      | 373 ++++++++++++++++++++++++++++++++---
>   drivers/gpu/drm/i915/intel_drv.h     |  10 +
>   include/drm/drm_dp_helper.h          |  31 ++-
>   include/uapi/drm/i915_drm.h          |   1 +
>   12 files changed, 618 insertions(+), 26 deletions(-)
>

All looks good from code point of view. Not yet tested on a HSW system 
as I do not have one right now.

Reviewed-by: Shobhit Kumar <shobhit.kumar@intel.com>