From: Ian Abbott <abbotti@mev.co.uk>
To: Ian Abbott <ian.abbott@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"oliver@schinagl.nl" <oliver@schinagl.nl>,
"linux@roeck-us.net" <linux@roeck-us.net>
Subject: Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups
Date: Mon, 15 Jul 2013 10:56:38 +0100 [thread overview]
Message-ID: <51E3C756.1080807@mev.co.uk> (raw)
In-Reply-To: <51E3C3E0.1050906@mev.co.uk>
On 2013-07-15 10:41, Ian Abbott wrote:
> On 2013-07-15 00:05, Greg Kroah-Hartman wrote:
>> Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later. I
>> considered it, but that would also mean a BUS_PATTR() and the like, which I
>> guess works, but I hate even a _hint_ of "Hungarian" notation, which this
>> implies.
>>
>> Anyone else have a better name for this macro:
>> #define DEVICE_PATTR(_name) &dev_attr_##_name.attr
>> that they can think of? It will cut down on the typing done for
>> attribute lists.
>
> DEVICE_ATTR_P or DEV_ATTR_P to save typing. Or would that be confused
> with the P convention[1]? If so, DEVICE_ATTR_PTR or DEV_ATTR_PTR could
> be used.
>
> [1] see Jargon File.
Then again, those follow the naming of DEVICE_ATTR_RO and DEVICE_ATTR_RW
too closely. Time for someone else to do a bit of bike-shedding.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2013-07-15 9:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 23:05 [PATCH v3 01/10] Driver core and sysfs changes for attribute groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 01/10] sysfs.h: add __ATTR_RW() macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 02/10] sysfs.h: add ATTRIBUTE_GROUPS() macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 03/10] sysfs.h: add BIN_ATTR macro Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 04/10] driver core: device.h: add RW and RO attribute macros Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 05/10] sysfs: add support for binary attributes in groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 06/10] sysfs: prevent warning when only using binary attributes Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 07/10] driver core: Introduce device_create_groups Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 08/10] driver core: add default groups to struct class Greg Kroah-Hartman
2013-07-14 23:05 ` [PATCH 09/10] sysfs: add more helper macro's for (bin_)attribute(_groups) Greg Kroah-Hartman
2013-07-14 23:06 ` [PATCH 10/10] sysfs: use file mode defines from stat.h Greg Kroah-Hartman
2013-07-15 0:27 ` [PATCH v3 01/10] Driver core and sysfs changes for attribute groups Stephen Rothwell
2013-07-15 0:32 ` Greg Kroah-Hartman
2013-07-15 9:41 ` Ian Abbott
2013-07-15 9:56 ` Ian Abbott [this message]
2013-07-18 23:54 ` Guenter Roeck
2013-07-19 0:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E3C756.1080807@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oliver@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.