From: Felix Fietkau <nbd@openwrt.org>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
krzysiek@podlesie.net
Subject: Re: [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue
Date: Mon, 15 Jul 2013 14:54:02 +0200 [thread overview]
Message-ID: <51E3F0EA.3060603@openwrt.org> (raw)
In-Reply-To: <1373892651.2062.11.camel@joe-AO722>
On 2013-07-15 2:50 PM, Joe Perches wrote:
> On Mon, 2013-07-15 at 14:35 +0200, Felix Fietkau wrote:
>> When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move
>> the assignment further down, after the rate_control_send_low call.
>>
>> Reported-by: Krzysztof Mazur <krzysiek@podlesie.net>
>> Cc: stable@vger.kernel.org # 3.10
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>
> Why should this be marked for stable?
>
> It's a local reference only, it's not used.
>
> It's like suggesting that all the initialized
> automatics should not be set until after
> rate_control_set_low is called.
mi is set to priv_sta. It can be NULL. The case of priv_sta==NULL is
caught by rate_control_send_low and causes it to bail out.
- Felix
next prev parent reply other threads:[~2013-07-15 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 12:35 [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue Felix Fietkau
2013-07-15 12:50 ` Joe Perches
2013-07-15 12:54 ` Felix Fietkau [this message]
2013-07-15 13:31 ` Joe Perches
2013-07-15 17:32 ` Krzysztof Mazur
2013-07-16 14:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E3F0EA.3060603@openwrt.org \
--to=nbd@openwrt.org \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=krzysiek@podlesie.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.