Re: [Qemu-devel] [PATCH] exec.c: Pass correct pointer type to qemu_ram_ptr_length

[Paolo Bonzini <pbonzini@redhat.com>]

Il 08/07/2013 10:44, Peter Maydell ha scritto:
> Commit e3127ae0 introduced a problem where we're passing a
> hwaddr* to qemu_ram_ptr_length() but it wants a ram_addr_t*;
> this will cause problems on 32 bit hosts and in any case
> provokes a clang warning on MacOSX:
> 
>   CC    arm-softmmu/exec.o
> exec.c:2164:46: warning: incompatible pointer types passing 'hwaddr *'
> (aka 'unsigned long long *') to parameter of type 'ram_addr_t *'
> (aka 'unsigned long *')
> [-Wincompatible-pointer-types]
>     return qemu_ram_ptr_length(raddr + base, plen);
>                                              ^~~~
> exec.c:1392:63: note: passing argument to parameter 'size' here
> static void *qemu_ram_ptr_length(ram_addr_t addr, ram_addr_t *size)
>                                                               ^
> 
> Since this function is only used in one place, change its
> prototype to pass a hwaddr* rather than a ram_addr_t*,
> rather than contorting the calling code to get the type right.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exec.c b/exec.c
> index 03fdf7e..50d29de 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1389,7 +1389,7 @@ static void *qemu_safe_ram_ptr(ram_addr_t addr)
>  
>  /* Return a host pointer to guest's ram. Similar to qemu_get_ram_ptr
>   * but takes a size argument */
> -static void *qemu_ram_ptr_length(ram_addr_t addr, ram_addr_t *size)
> +static void *qemu_ram_ptr_length(ram_addr_t addr, hwaddr *size)
>  {
>      if (*size == 0) {
>          return NULL;
> 

Thanks, applying it to my memory tree.

Paolo