From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/control: protect functions with CONFIG_HIBERNATE_CALLBACKS to avoid warning Date: Mon, 15 Jul 2013 16:47:01 +0100 Message-ID: <51E41975.3070706@citrix.com> References: <1373898275-15765-1-git-send-email-julien.grall@linaro.org> <20130715152714.GD5774@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130715152714.GD5774@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/15/2013 04:27 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 15, 2013 at 03:24:35PM +0100, Julien Grall wrote: >> If CONFIG_HIBERNATE_CALLBACKS is not set gcc will issue warnings: >> drivers/xen/manage.c:46:13: warning: 'xen_hvm_post_suspend' defined but not used [-Wunused-function] >> drivers/xen/manage.c:52:13: warning: 'xen_pre_suspend' defined but not used [-Wunused-function] >> drivers/xen/manage.c:59:13: warning: 'xen_post_suspend' defined but not used [-Wunused-function] > > Have you checked the upstream kernel? My apologies, I forgot to check upstream for this patch. -- Julien