Re: [PATCH v2] brcmsmac: Further reduce log spam from tx phy messages

[John Greene <jogreene@redhat.com>]

On 07/15/2013 12:26 PM, Arend van Spriel wrote:
> On 07/15/13 15:31, John Greene wrote:
>> Relegate 2 phy messages to debug status as they create excessive
>> log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
>> This is a follow on to net-next 99e94940697adec4f84758adb2db71f4a82c7ba5:
>> brcmsmac: Reduce log spam in heavy tx, make err print in debug
>>
>>   brcmsmac bcma0:0: phyerr 0x10, rate 0x14
>>   brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
>> ampdu tx phy error (0x10)
>
> Hi John,
>
> Thanks for the patch. Still trying to find where these are coming from,
> but we seem to have slight variation of this device not showing this.
>
>> ver 2: Two trivial whitespace fixes.
>
> this kind of info recommended to be placed under the signed-off line so
> it does not end up in the git log. Apart from that you can add my ack.
>
> Acked-by: Arend van Spriel <arend@broadcom.com>
>> Signed-off-by: John Greene<jogreene@redhat.com>
>> ---
> so here
> ---
>>   drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 6 +++---
>>   drivers/net/wireless/brcm80211/brcmsmac/main.c  | 4 ++--
>>   2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>> b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>> index bd98285..fa391e4 100644
>> --- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>> +++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>> @@ -928,9 +928,9 @@ brcms_c_ampdu_dotxstatus_complete(struct
>> ampdu_info *ampdu, struct scb *scb,
>>               }
>>           } else if (txs->phyerr) {
>>               update_rate = false;
>> -            brcms_err(wlc->hw->d11core,
>> -                  "%s: ampdu tx phy error (0x%x)\n",
>> -                  __func__, txs->phyerr);
>> +            brcms_dbg_ht(wlc->hw->d11core,
>> +                     "%s: ampdu tx phy error (0x%x)\n",
>> +                     __func__, txs->phyerr);
>>           }
>>       }
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c
>> b/drivers/net/wireless/brcm80211/brcmsmac/main.c
>> index 9fd6f2f..7ca10bf 100644
>> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
>> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
>> @@ -882,8 +882,8 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc,
>> struct tx_status *txs)
>>       mcl = le16_to_cpu(txh->MacTxControlLow);
>>
>>       if (txs->phyerr)
>> -        brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> -              txs->phyerr, txh->MainRates);
>> +        brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> +                 txs->phyerr, txh->MainRates);
>>
>>       if (txs->frameid != le16_to_cpu(txh->TxFrameID)) {
>>           brcms_err(wlc->hw->d11core, "frameid != txh->TxFrameID\n");
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thanks Arend.  Look forward to hearing about root cause.  From what I've 
seen, it's not a low signal issue: users have strong signal (>-60) but 
PHY is reporting errors because the rate fallback exhausted rates list? 
  Anything I can do to gather info from users?  Have some willing users.

Third time the charm for this patch. It's Monday.  v3 on the way.

-- 
John Greene