From: "H. Peter Anvin" <hpa@zytor.com>
To: Kees Cook <keescook@chromium.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
pageexec@gmail.com, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/urgent] x86: Make sure IDT is page aligned
Date: Mon, 15 Jul 2013 11:09:17 -0700 [thread overview]
Message-ID: <51E43ACD.9080307@zytor.com> (raw)
In-Reply-To: <CAE9FiQXvfopU1SYs3OFQk8rXVgq-Hbhw6gB49u5H4O70Tx12+A@mail.gmail.com>
On 07/13/2013 02:34 PM, Yinghai Lu wrote:
>
> can we use put all idt_table related in to __bss.aligned section ...?
>
> like
> gate_desc idt_table[NR_VECTORS] __page_aligned_bss;
>
I think this is the best solution all around... it not only solves the
initializer problem but also reduces the size of data.
A long, long time ago in a galaxy far, far away I believe the IDT got
set up before we cleared bss, but that is no longer the case as we now
clear bss very, very early (on 32 bits before paging is even enabled.)
Still, it would seem that the minimal solution, if we need something for
3.11/stable, is to simply fix the alignment statement in head_64.S
(optionally move to .bss..page_aligned) and then do the proper cleanup
for 3.12. If you could prepare a patch for the former (please include
the descriptions we discussed over IRC) and a patchset for the latter it
would be good.
Thanks,
-hpa
next prev parent reply other threads:[~2013-07-15 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 22:50 [PATCH v3] x86: make sure IDT is page aligned Kees Cook
2013-07-13 3:21 ` [tip:x86/urgent] x86: Make " tip-bot for Kees Cook
2013-07-13 20:39 ` Yinghai Lu
2013-07-13 21:34 ` Yinghai Lu
2013-07-15 18:09 ` H. Peter Anvin [this message]
2013-07-15 18:37 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2013-07-16 18:34 [PATCH v5] x86: make " Kees Cook
2013-07-16 22:33 ` [tip:x86/urgent] x86: Make " tip-bot for Kees Cook
2013-07-17 18:57 ` Yinghai Lu
2013-07-17 19:57 ` H. Peter Anvin
2013-07-18 7:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E43ACD.9080307@zytor.com \
--to=hpa@zytor.com \
--cc=hpa@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pageexec@gmail.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.