Re: [PATCH tegra-cbootimage-configs] Add Toradex Colibri T20 configurations

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 07/02/2013 09:31 AM, Stephen Warren wrote:
> On 06/28/2013 02:27 PM, Lucas Stach wrote:
>> The Colibri T20 COM comes in two different versions, which can both
>> boot from NAND or SD-Card.
> 
>> diff --git a/tegra20/toradex/colibri-t20/colibri-t20_256_hsmmc.bct.cfg b/tegra20/toradex/colibri-t20/colibri-t20_256_hsmmc.bct.cfg
> ...
>> +OdmData       = 0x200C0000;
> 
>> diff --git a/tegra20/toradex/colibri-t20/colibri-t20_512_hsmmc.bct.cfg b/tegra20/toradex/colibri-t20/colibri-t20_512_hsmmc.bct.cfg
> ...
>> +OdmData       = 0x400C0000;
> 
> Those ODMDATA values don't look correct. The first nibble should be set
> as follows:
> 
> 1: 256MiB
> 2: 512MiB
> 3: 1GiB
> 
> ... and I assume that the "256" and "515" in the filenames represent the
> RAM size?
> 
> Nit: Many files have an extra blank line at the end.

Lucas, any comment on the ODMDATA setting? That's all that's preventing
this patch from being merged.