From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uyrr8-0005RY-DF for qemu-devel@nongnu.org; Mon, 15 Jul 2013 19:06:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uyrr7-0008F5-7g for qemu-devel@nongnu.org; Mon, 15 Jul 2013 19:06:58 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:55504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uyrr7-0008EP-1o for qemu-devel@nongnu.org; Mon, 15 Jul 2013 19:06:57 -0400 Received: by mail-pb0-f52.google.com with SMTP id xa12so15517pbc.11 for ; Mon, 15 Jul 2013 16:06:53 -0700 (PDT) Message-ID: <51E48086.1040307@ozlabs.ru> Date: Tue, 16 Jul 2013 09:06:46 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1373614639-15523-1-git-send-email-aik@ozlabs.ru> <20130713080309.GA11522@voom.redhat.com> <51E2A614.5010402@ozlabs.ru> <87vc4bamst.fsf@codemonkey.ws> In-Reply-To: <87vc4bamst.fsf@codemonkey.ws> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alexander Graf , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson On 07/16/2013 01:02 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> On 07/13/2013 06:03 PM, David Gibson wrote: >>> On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote: >>>> sPAPR PHB emulates IO ports on PCI via a special memory region which >>>> routes all reads/writes further via cpu_in*/cpu_out* which are eventually >>>> processed by MemoryRegionOps implemented by devices. >> >>> Hrm. That double dispatch was a workaround for bugs in the plain >>> memory region dispatching which meant we couldn't directly map regions >>> in memory space to IO areas. >>> >>> It would be worth checking if that workaround is still necessary. >> >> Hm. Good point, thanks! It seems memory_region_init_io is not necessary any >> more. Will make a patch for it. > > You should try the latest qemu.git commit. There shouldn't be a problem > anymore. Does this mean sPAPR still needs an additional IO memory region? It looks redundand and everything (almost) works without it... -- Alexey