From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qiaonuohan@cn.fujitsu.com>) id 1Uyw96-00035j-5x
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 23:41:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <qiaonuohan@cn.fujitsu.com>) id 1Uyw93-0008AT-Oi
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 23:41:48 -0400
Received: from [222.73.24.84] (port=60910 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qiaonuohan@cn.fujitsu.com>) id 1Uyw93-00087U-Dm
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 23:41:45 -0400
Message-ID: <51E4C0BF.2040806@cn.fujitsu.com>
Date: Tue, 16 Jul 2013 11:40:47 +0800
From: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
MIME-Version: 1.0
References: <1373355014-14846-1-git-send-email-qiaonuohan@cn.fujitsu.com>
	<1373355014-14846-9-git-send-email-qiaonuohan@cn.fujitsu.com>
	<20130716024358.GD32278@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130716024358.GD32278@stefanha-thinkpad.redhat.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Subject: Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, zhangxh@cn.fujitsu.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de

Thanks for your comments!


On 07/16/2013 10:43 AM, Stefan Hajnoczi wrote:
>> @@ -130,6 +139,13 @@ typedef struct DataCache {
>> >        off_t offset;       /* offset of the file */
>> >    } DataCache;
>> >
>> >  +typedef struct PageDesc {
>> >  +    off_t offset;                   /* the offset of the page data*/
> The guest may be 32-bit or 64-bit, independently of the QEMU host
> wordsize.  Is off_t correct when running a 64-bit guest on a 32-bit
> host?
>
> I guess you are assuming off_t == uint64_t here?
>

The 'offset' should be 64-bit in kdump format both on 32-bit and 64-bit. And I
will avoid using off_t in structure used by kdump format. Thanks for pointing
it out.

-- 
Regards
Qiao Nuohan