From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz0jl-0008Es-KI for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:35:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz0jj-0006Vh-NQ for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:35:57 -0400 Message-ID: <51E505E3.8050707@adacore.com> Date: Tue, 16 Jul 2013 10:35:47 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1373476202-11277-1-git-send-email-chouteau@adacore.com> <1373476202-11277-3-git-send-email-chouteau@adacore.com> <51E405E4.7080406@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de On 07/16/2013 03:06 AM, Peter Crosthwaite wrote: >>>> + >>>> + memory_region_init_io(&etsec->io_area, OBJECT(etsec), &etsec_ops, etsec, >>>> + "eTSEC", 0x1000); >>> >>> Constant size memory_region_init_io should be migrated to the Object::Init fm. >>> >> >> What is Object::Init()? Do you have an example? >> > > hw/dma/xilinx_axidma.c - xilinx_axidma_init() and > xilinx_axidma_realize() has an example of splitting init task between > early and late. Note the memory_region_init_io is in the _init. > OK thanks, -- Fabien Chouteau