From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz0lY-0000s6-Nv for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz0lV-0006rr-9A for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:37:48 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:65161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz0lV-0006rk-4P for qemu-devel@nongnu.org; Tue, 16 Jul 2013 04:37:45 -0400 Received: by mail-ie0-f175.google.com with SMTP id a11so989860iee.20 for ; Tue, 16 Jul 2013 01:37:44 -0700 (PDT) Message-ID: <51E5064B.3090608@ozlabs.ru> Date: Tue, 16 Jul 2013 18:37:31 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1373951995-9866-1-git-send-email-aik@ozlabs.ru> <51E4E636.8010603@redhat.com> <0B82AB0E-3434-4EFE-A3A4-41CAF169B7F7@suse.de> In-Reply-To: <0B82AB0E-3434-4EFE-A3A4-41CAF169B7F7@suse.de> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Anthony Liguori , "qemu-devel@nongnu.org" , "qemu-ppc@nongnu.org" , Paolo Bonzini , Paul Mackerras , David Gibson On 07/16/2013 06:32 PM, Alexander Graf wrote: > > > Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : > >> Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: >>> In the past, IO space could not be mapped into the memory address space >>> so we introduced a workaround for that. Nowadays it does not look >>> necessary so we can remove the workaround and make sPAPR PCI >>> configuration simplier. >>> >>> This also removes all byte swappings as it is not PHB's to take care >>> of endiannes - devices should do convertion if they want to. And almost >>> every PCI device which uses IO ports does that by registering IO ports >>> region with memory_region_init_io() (Intel e1000, RTL8139, virtio). >>> >>> However VGA uses MemoryRegionPortio which does not support endiannes >>> but it still expects the convertion to be done. For this case only, >>> this patch adds LITTLE_ENDIAN flag to portio_ops. Tests on PPC64 show >>> that other devices are not affected by this change. x86 systems should >>> not suffer either as having LITTLE_ENDIAN there has no effect. >>> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> >>> This removes bugs at least from SPAPR so any further fixes should be equal >>> for all platforms and hopefully will break all platform altogether but not >>> just PPC64-pSeries :) >>> >>> Did I miss anything here? >> >> No, I don't think so. The patch looks good. > > ... and will break all Mac targets again, no? Not to speak of non-ppc devices. Like what? I do not mind/argue/discuss, may be it breaks, I am just looking for good examples to test. -- Alexey