From mboxrd@z Thu Jan 1 00:00:00 1970 From: Younger Liu Subject: [RESENT PATCH] logfs: Check for the return value after calling find_or_create_page() Date: Tue, 16 Jul 2013 17:33:07 +0800 Message-ID: <51E51353.3060501@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , , , "linux-fsdevel@vger.kernel.org" To: Andrew Morton Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:64360 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101Ab3GPJie (ORCPT ); Tue, 16 Jul 2013 05:38:34 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: In get_mapping_page(), after calling find_or_create_page(), the return value should be checked. Signed-off-by: Younger Liu --- fs/logfs/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c index 038da09..2641e94 100644 --- a/fs/logfs/segment.c +++ b/fs/logfs/segment.c @@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct super_block *sb, pgoff_t index, page = read_cache_page(mapping, index, filler, sb); else { page = find_or_create_page(mapping, index, GFP_NOFS); - unlock_page(page); + if(page) + unlock_page(page); } return page; } -- 1.7.9.7