From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH resend 3/3] pciif: add multi-vector-MSI command Date: Tue, 16 Jul 2013 12:19:30 +0100 Message-ID: <51E52C42.1000808@citrix.com> References: <51E535F902000078000E547F@nat28.tlf.novell.com> <51E5395002000078000E54B2@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3984536607748918799==" Return-path: In-Reply-To: <51E5395002000078000E54B2@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , xiantao.zhang@intel.com, xen-devel List-Id: xen-devel@lists.xenproject.org --===============3984536607748918799== Content-Type: multipart/alternative; boundary="------------050101020009030207090705" --------------050101020009030207090705 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 16/07/13 11:15, Jan Beulich wrote: > The requested vector count is to be passed in struct xen_pci_op's info > field. Upon failure, if a smaller vector count might work, the backend > will pass that smaller count in the value field (which so far is always > being set to zero in the error path). > > Signed-off-by: Jan Beulich > > --- a/xen/include/public/io/pciif.h > +++ b/xen/include/public/io/pciif.h > @@ -46,6 +46,7 @@ > #define XEN_PCI_OP_aer_resume (7) > #define XEN_PCI_OP_aer_mmio (8) > #define XEN_PCI_OP_aer_slotreset (9) > +#define XEN_PCI_OP_enable_multi_msi (10) /* Be sure to bump this number if you change this file */ #define XEN_PCI_MAGIC "7" Should you bump this version, or is the comment stale? The only in-tree consumer I can find is MiniOS's pcifront, which writes it into xenstore. ~Andrew > > /* xen_pci_op error numbers */ > #define XEN_PCI_ERR_success (0) > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------050101020009030207090705 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 16/07/13 11:15, Jan Beulich wrote:
The requested vector count is to be passed in struct xen_pci_op's info
field. Upon failure, if a smaller vector count might work, the backend
will pass that smaller count in the value field (which so far is always
being set to zero in the error path).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/public/io/pciif.h
+++ b/xen/include/public/io/pciif.h
@@ -46,6 +46,7 @@
 #define XEN_PCI_OP_aer_resume		(7)
 #define XEN_PCI_OP_aer_mmio		(8)
 #define XEN_PCI_OP_aer_slotreset	(9)
+#define XEN_PCI_OP_enable_multi_msi	(10)

/* Be sure to bump this number if you change this file */
#define XEN_PCI_MAGIC "7"

Should you bump this version, or is the comment stale?  The only in-tree consumer I can find is MiniOS's pcifront, which writes it into xenstore.

~Andrew

 
 /* xen_pci_op error numbers */
 #define XEN_PCI_ERR_success          (0)






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------050101020009030207090705-- --===============3984536607748918799== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3984536607748918799==--