From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active() Date: Tue, 16 Jul 2013 15:48:16 +0400 Message-ID: <51E53300.6010000@cogentembedded.com> References: <1373951920-31699-1-git-send-email-xtfeng@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f41.google.com ([209.85.215.41]:47155 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932210Ab3GPLsR (ORCPT ); Tue, 16 Jul 2013 07:48:17 -0400 Received: by mail-la0-f41.google.com with SMTP id fn20so443967lab.0 for ; Tue, 16 Jul 2013 04:48:16 -0700 (PDT) In-Reply-To: <1373951920-31699-1-git-send-email-xtfeng@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Xiaotian Feng Cc: Alexander Gordeev , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. On 16-07-2013 9:18, Xiaotian Feng wrote: > commit b29900e6 introuded a regression, which resulted Null pointer Please also specify that commit's summary in parens. > dereference for achi host with dummy ports. For ahci ports, when the > port is dummy port, its private_data will be NULL, as ata_dummy_port_ops > doesn't support ->port_start. > Reported-and-tested-by: Alex Williamson > Signed-off-by: Xiaotian Feng > Cc: Alexander Gordeev > Cc: Tejun Heo > Cc: linux-ide@vger.kernel.org > Cc: linux-kernel@vger.kernel.org MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329Ab3GPLsT (ORCPT ); Tue, 16 Jul 2013 07:48:19 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:63719 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932191Ab3GPLsR (ORCPT ); Tue, 16 Jul 2013 07:48:17 -0400 Message-ID: <51E53300.6010000@cogentembedded.com> Date: Tue, 16 Jul 2013 15:48:16 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Xiaotian Feng CC: unlisted-recipients:"; Alexander Gordeev" , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Illegal-Object: Syntax error in CC: address found on vger.kernel.org: CC: unlisted-recipients:;Alexander Gordeev ^-missing end of address Subject: Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active() References: <1373951920-31699-1-git-send-email-xtfeng@gmail.com> In-Reply-To: <1373951920-31699-1-git-send-email-xtfeng@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 16-07-2013 9:18, Xiaotian Feng wrote: > commit b29900e6 introuded a regression, which resulted Null pointer Please also specify that commit's summary in parens. > dereference for achi host with dummy ports. For ahci ports, when the > port is dummy port, its private_data will be NULL, as ata_dummy_port_ops > doesn't support ->port_start. > Reported-and-tested-by: Alex Williamson > Signed-off-by: Xiaotian Feng > Cc: Alexander Gordeev > Cc: Tejun Heo > Cc: linux-ide@vger.kernel.org > Cc: linux-kernel@vger.kernel.org MBR, Sergei