From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz5FQ-0001jo-TT for qemu-devel@nongnu.org; Tue, 16 Jul 2013 09:25:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz5FP-0007sB-3i for qemu-devel@nongnu.org; Tue, 16 Jul 2013 09:24:56 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:47323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz5FO-0007rt-T8 for qemu-devel@nongnu.org; Tue, 16 Jul 2013 09:24:55 -0400 Received: by mail-pb0-f48.google.com with SMTP id ma3so692226pbc.7 for ; Tue, 16 Jul 2013 06:24:53 -0700 (PDT) Message-ID: <51E5499B.70708@ozlabs.ru> Date: Tue, 16 Jul 2013 23:24:43 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1373901083-18730-1-git-send-email-aliguori@us.ibm.com> <51E51C08.20202@ozlabs.ru> <8738reelbt.fsf@codemonkey.ws> <51E53DFA.6090506@ozlabs.ru> <51E54119.903@ozlabs.ru> In-Reply-To: <51E54119.903@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/11] pseries: migration and QOM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson On 07/16/2013 10:48 PM, Alexey Kardashevskiy wrote: > On 07/16/2013 10:35 PM, Alexey Kardashevskiy wrote: >> On 07/16/2013 10:33 PM, Anthony Liguori wrote: >>> Alexey Kardashevskiy writes: >>> >>>> On 07/16/2013 01:11 AM, Anthony Liguori wrote: >>>>> This series is based on Alexey's series: >>>>> >>>>> spapr: migration, pci, msi, power8 >>>>> >>>>> Which in turn was based on work by David Gibson. >>>>> >>>>> I've removed the bits not related to migration and made the >>>>> following changes: >>>>> >>>>> 1) QOMify TCE tables and XICS >>>>> >>>>> 2) Do everything in terms of VMStateDescriptions >>>>> >>>>> 3) Fix endianness problem with TCE table translation >>>>> a) Drop the VMSTATE_DIVIDE thing in the process >>>>> >>>>> I've tested this with a TCG pseries guest on an x86_64 host. >>>> >>>> >>>> It did not compile (fixed, patch is posted) and it fails to migrate with >>>> enabled KVM. >>> >>> With in-kernel XICS? That's not in this series.. >> >> No, as is, without any of my patches. I suspect rather HPTE than XICS though. > > I was wrong. vmstate_spapr_tce_table is broken :) Here it is: diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 709cc34..3d4a1fc 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -148,6 +148,7 @@ static int spapr_tce_table_realize(DeviceState *dev) * sizeof(uint64_t); tcet->table = g_malloc0(table_size); } + tcet->nb_table = tcet->window_size >> SPAPR_TCE_PAGE_SHIFT; #ifdef DEBUG_TCE fprintf(stderr, "spapr_iommu: New TCE table @ %p, liobn=0x%x, " Honestly, I liked David's approach more when we did not need any extra parameter to sync :( -- Alexey