From: "Andreas Färber" <afaerber@suse.de>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] target-openrisc: Free typename
Date: Tue, 16 Jul 2013 16:19:02 +0200 [thread overview]
Message-ID: <51E55656.60201@suse.de> (raw)
In-Reply-To: <1373940029-7455-4-git-send-email-proljc@gmail.com>
Am 16.07.2013 04:00, schrieb Jia Liu:
> We should free typename here.
>
> Signed-off-by: Jia Liu <proljc@gmail.com>
> ---
> target-openrisc/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c
> index 6d40f1b..e348df0 100644
> --- a/target-openrisc/cpu.c
> +++ b/target-openrisc/cpu.c
> @@ -99,6 +99,7 @@ static ObjectClass *openrisc_cpu_class_by_name(const char *cpu_model)
>
> typename = g_strdup_printf("%s-" TYPE_OPENRISC_CPU, cpu_model);
> oc = object_class_by_name(typename);
> + g_free(typename);
> if (oc != NULL && (!object_class_dynamic_cast(oc, TYPE_OPENRISC_CPU) ||
> object_class_is_abstract(oc))) {
> return NULL;
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-16 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 2:00 [Qemu-devel] [PATCH V2 0/4] target-openrisc hw/openrisc: Some OpenRISC fix Jia Liu
2013-07-16 2:00 ` [Qemu-devel] [PATCH V2 1/4] hw/openrisc: Indent typo Jia Liu
2013-07-16 2:00 ` [Qemu-devel] [PATCH V2 2/4] hw/openrisc: Use stderr output instead of qemu_log Jia Liu
2013-07-16 2:00 ` [Qemu-devel] [PATCH 3/4] target-openrisc: Free typename Jia Liu
2013-07-16 2:05 ` Jia Liu
2013-07-16 14:19 ` Andreas Färber [this message]
2013-07-17 1:34 ` Jia Liu
2013-07-16 2:00 ` [Qemu-devel] [PATCH 4/4] target-openrisc: Fix cpu_model by name Jia Liu
2013-07-16 2:06 ` Jia Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E55656.60201@suse.de \
--to=afaerber@suse.de \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.