From: Mark Levedahl <mlevedahl@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: t3032 incompatible with Cygwin/Windows
Date: Tue, 16 Jul 2013 14:33:35 -0400 [thread overview]
Message-ID: <51E591FF.7030600@gmail.com> (raw)
Subtests 6,7, and 9 of t3032 fail on Cygwin, and I presume will fail on
msysgit for similar reasons. Looking at test 6, the expected result is a
line ending with \r\n in text.txt. This line is extracted with grep
(grep 'justice and holiness' text.txt > actual), with unavoidable result
that on Cygwin the line ending is \n. This happens because on Cygwin,
the text utils are compiled to open files in text mode meaning than \n
and \r\n are both recognized as EOL markers. Thus, even though text.txt
is an exact match for what is created on Linux, the test fails because
\r\n cannot be distinguished by the available tools.
I'm not sure the right way forward. I did confirm that by substituting
"q_to_tab" for "q_to_cr" in t3032, the test pass on Cygwin and on Linux.
Perhaps t3032 should be so amended to avoid use of a non-portable line
ending construct?
Mark
next reply other threads:[~2013-07-16 18:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 18:33 Mark Levedahl [this message]
2013-07-16 18:49 ` [PATCH] t3032 - make compatible with systems using \r\n as a line ending Mark Levedahl
2013-07-16 18:59 ` Jonathan Nieder
2013-07-16 19:44 ` Mark Levedahl
2013-07-16 20:26 ` Mark Levedahl
2013-07-16 20:32 ` Mark Levedahl
2013-07-17 19:33 ` Junio C Hamano
2013-07-18 21:44 ` [PATCH] test-lib.sh - define and use GREP_STRIPS_CR Mark Levedahl
2013-07-20 19:41 ` Ramsay Jones
2013-07-21 21:04 ` Junio C Hamano
2013-07-18 19:19 ` [PATCH] t3032 - make compatible with systems using \r\n as a line ending Ramsay Jones
2013-07-18 21:47 ` Mark Levedahl
2013-07-16 18:56 ` t3032 incompatible with Cygwin/Windows Jonathan Nieder
2013-07-18 19:11 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E591FF.7030600@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.