From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzLd8-0000me-7O for qemu-devel@nongnu.org; Wed, 17 Jul 2013 02:54:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzLd6-0005Vq-Uj for qemu-devel@nongnu.org; Wed, 17 Jul 2013 02:54:30 -0400 Received: from mout.web.de ([212.227.17.12]:51532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzLd6-0005Vi-LP for qemu-devel@nongnu.org; Wed, 17 Jul 2013 02:54:28 -0400 Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0Lj2TO-1UQp1p0ges-00dFlx for ; Wed, 17 Jul 2013 08:54:27 +0200 Message-ID: <51E63FA1.8090001@web.de> Date: Wed, 17 Jul 2013 08:54:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1361367806-4599-1-git-send-email-aliguori@us.ibm.com> <1361367806-4599-10-git-send-email-aliguori@us.ibm.com> <5127B788.40701@siemens.com> <5127BBC1.5070607@siemens.com> <512B7B8B.1000402@siemens.com> <87zjys9zcv.fsf@codemonkey.ws> <512B86E7.80603@siemens.com> <514F40A2.6000202@web.de> <5189836B.2080000@web.de> In-Reply-To: <5189836B.2080000@web.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2SOQIDLJGIEVWDDMKKDHW" Subject: Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Jordan Justen , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SOQIDLJGIEVWDDMKKDHW Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-05-08 00:42, Jan Kiszka wrote: > On 2013-05-07 23:03, Jordan Justen wrote: >> On Sun, Mar 24, 2013 at 11:06 AM, Jan Kiszka wrote= : >>> On 2013-02-25 16:44, Jan Kiszka wrote: >>>> On 2013-02-25 16:39, Anthony Liguori wrote: >>>>> Jan Kiszka writes: >>>>> >>>>>> This is in fact very simply: When the input in grabbed, everything= >>>>>> should be exclusively passed to the guest - except it has our magi= c >>>>>> CTRL-ALT modifier set. Then let GTK filter out those accels that a= re in >>>>>> use. When checking the modifier state, we just need to filter out = NUM >>>>>> and CAPS lock. >>>>> >>>>> Can you explain what you're fixing? >>>> >>>> That it's not filtering what it is supposed to. >>>> >>>>> >>>>> We shouldn't hard code modifiers like this. The reason you give >>>>> accelerators paths like this is so that they can be overridden by a= >>>>> user. >>>>> >>>>> That's why I filtered by path. Once we're running, we shouldn't as= sume >>>>> that accelerators use the modifiers we started with. >>>> >>>> Your path-based filtering does not work as it uses an unsupported >>>> internal function (see my other mail). >>>> >>>> We can make the modifier configurable via QEMU means (command line >>>> parameter, gconfig, whatever). But let's get the basics working firs= t. >>> >>> The bug still exists, my patch still applies. Unless you have some id= ea >>> for a better solution, please apply this for now so that CTRL-q insid= e a >>> guest doesn't kill more kittens. >> >> I finally built qemu with gtk support, and in general it seems like a >> great improvement over SDL. >> >> ...except ctrl-q to quit the VM. Why is binding a hotkey to quit a >> good idea at all? It seems kind of like attaching your computer's >> power to a wall-switch. :) >=20 > Yeah, this bug should really be fixed in some way before 1.5 is release= d > because GTK will be default. Anthony, what is the status of your > experiments with alternative solutions? Re-ping on this, now for 1.6 (with the option to backport the fix). What defines the modifiers to be used for the accelerators? Is there an interface to query them (to avoid my original hard-coding)? Jan ------enig2SOQIDLJGIEVWDDMKKDHW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlHmP6EACgkQitSsb3rl5xQuiwCfZ/WtYe1TM9jqqkO9nt3C5Y+0 z4wAoMBz8f0PSlFVLxCE8aUeDmOmMb/d =ousK -----END PGP SIGNATURE----- ------enig2SOQIDLJGIEVWDDMKKDHW--