diff for duplicates of <51E641C7.4000107@nvidia.com> diff --git a/a/1.txt b/N1/1.txt index ca52048..356b92d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,7 +10,7 @@ On 07/16/2013 12:57 AM, Jean Delvare wrote: How about "Introduce status bits" > ->> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/hwmon/lm90.c | 72 ++++++++++++++++++++++++++++++++++---------------- >> 1 file changed, 49 insertions(+), 23 deletions(-) @@ -56,10 +56,10 @@ Ok, I will remove it. >> + >> + lm90_read_reg(client, LM90_REG_R_STATUS, &status); >> + ->> + if (data->kind == max6696) +>> + if (data->kind = max6696) >> + lm90_read_reg(client, MAX6696_REG_R_STATUS2, &status2); >> + ->> + if ((status & 0x7f) == 0 && (status2 & 0xfe) == 0) +>> + if ((status & 0x7f) = 0 && (status2 & 0xfe) = 0) >> + return false; > > It's a bit disappointing to not use the freshly introduced constants. @@ -123,10 +123,10 @@ him back to talk about below issue. >> - >> - lm90_read_reg(client, LM90_REG_R_STATUS, &alarms); >> - ->> - if (data->kind == max6696) +>> - if (data->kind = max6696) >> - lm90_read_reg(client, MAX6696_REG_R_STATUS2, &alarms2); >> - ->> - if ((alarms & 0x7f) == 0 && (alarms2 & 0xfe) == 0) { +>> - if ((alarms & 0x7f) = 0 && (alarms2 & 0xfe) = 0) { >> + if (!lm90_is_tripped(client)) { > > You could swap the success and failure cases to avoid this negation. @@ -177,4 +177,10 @@ So we can read the status only once and pass it. >> && (alarms & data->alert_alarms)) { >> dev_dbg(&client->dev, "Disabling ALERT#\n"); > -> +> + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 190c755..3bbaf69 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,9 +2,9 @@ "ref\01373615287-18502-3-git-send-email-wni@nvidia.com\0" "ref\020130715185727.4ebde8c4@endymion.delvare\0" "ref\020130715185727.4ebde8c4-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Subject\0Re: [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit\0" - "Date\0Wed, 17 Jul 2013 15:03:35 +0800\0" + "From\0Wei Ni <wni@nvidia.com>\0" + "Subject\0Re: [lm-sensors] [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit\0" + "Date\0Wed, 17 Jul 2013 07:03:35 +0000\0" "To\0Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>\0" "Cc\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>" thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @@ -25,7 +25,7 @@ "How about \"Introduce status bits\"\n" "\n" "> \n" - ">> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">> ---\n" ">> drivers/hwmon/lm90.c | 72 ++++++++++++++++++++++++++++++++++----------------\n" ">> 1 file changed, 49 insertions(+), 23 deletions(-)\n" @@ -71,10 +71,10 @@ ">> +\n" ">> +\tlm90_read_reg(client, LM90_REG_R_STATUS, &status);\n" ">> +\n" - ">> +\tif (data->kind == max6696)\n" + ">> +\tif (data->kind = max6696)\n" ">> +\t\tlm90_read_reg(client, MAX6696_REG_R_STATUS2, &status2);\n" ">> +\n" - ">> +\tif ((status & 0x7f) == 0 && (status2 & 0xfe) == 0)\n" + ">> +\tif ((status & 0x7f) = 0 && (status2 & 0xfe) = 0)\n" ">> +\t\treturn false;\n" "> \n" "> It's a bit disappointing to not use the freshly introduced constants.\n" @@ -138,10 +138,10 @@ ">> -\n" ">> -\tlm90_read_reg(client, LM90_REG_R_STATUS, &alarms);\n" ">> -\n" - ">> -\tif (data->kind == max6696)\n" + ">> -\tif (data->kind = max6696)\n" ">> -\t\tlm90_read_reg(client, MAX6696_REG_R_STATUS2, &alarms2);\n" ">> -\n" - ">> -\tif ((alarms & 0x7f) == 0 && (alarms2 & 0xfe) == 0) {\n" + ">> -\tif ((alarms & 0x7f) = 0 && (alarms2 & 0xfe) = 0) {\n" ">> +\tif (!lm90_is_tripped(client)) {\n" "> \n" "> You could swap the success and failure cases to avoid this negation.\n" @@ -192,6 +192,12 @@ ">> \t\t && (alarms & data->alert_alarms)) {\n" ">> \t\t\tdev_dbg(&client->dev, \"Disabling ALERT#\\n\");\n" "> \n" - > + "> \n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -334afdbdd845566321838f2929d7f819809e3241b2a8f33a9fcac2e8d34fe46f +a3fa2ff1d473815e40c38efb4385ba1c4517eec89fe861c6b198ae850c5ae868
diff --git a/a/1.txt b/N2/1.txt index ca52048..2776d61 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -10,7 +10,7 @@ On 07/16/2013 12:57 AM, Jean Delvare wrote: How about "Introduce status bits" > ->> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> drivers/hwmon/lm90.c | 72 ++++++++++++++++++++++++++++++++++---------------- >> 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/a/content_digest b/N2/content_digest index 190c755..fac6a8c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,16 +1,15 @@ "ref\01373615287-18502-1-git-send-email-wni@nvidia.com\0" "ref\01373615287-18502-3-git-send-email-wni@nvidia.com\0" "ref\020130715185727.4ebde8c4@endymion.delvare\0" - "ref\020130715185727.4ebde8c4-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org\0" - "From\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" + "From\0Wei Ni <wni@nvidia.com>\0" "Subject\0Re: [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit\0" "Date\0Wed, 17 Jul 2013 15:03:35 +0800\0" - "To\0Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>\0" - "Cc\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>" - thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Jean Delvare <khali@linux-fr.org>\0" + "Cc\0Guenter Roeck <linux@roeck-us.net>" + thierry.reding@gmail.com <thierry.reding@gmail.com> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-tegra@vger.kernel.org <linux-tegra@vger.kernel.org>\0" "\00:1\0" "b\0" "On 07/16/2013 12:57 AM, Jean Delvare wrote:\n" @@ -25,7 +24,7 @@ "How about \"Introduce status bits\"\n" "\n" "> \n" - ">> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">> ---\n" ">> drivers/hwmon/lm90.c | 72 ++++++++++++++++++++++++++++++++++----------------\n" ">> 1 file changed, 49 insertions(+), 23 deletions(-)\n" @@ -194,4 +193,4 @@ "> \n" > -334afdbdd845566321838f2929d7f819809e3241b2a8f33a9fcac2e8d34fe46f +68b052da5846bbb6abc3f439a4ddeebd016b0f22a246a2da6a2655659549e33e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.