From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves
Date: Wed, 17 Jul 2013 10:11:07 +0200 [thread overview]
Message-ID: <51E6519B.6060609@redhat.com> (raw)
In-Reply-To: <9EDD71F21C4D65014805FB9B@nimrod.local>
Il 17/07/2013 10:07, Alex Bligh ha scritto:
> Stefan,
>
> --On 17 July 2013 11:02:30 +0800 Stefan Hajnoczi <stefanha@gmail.com>
> wrote:
>
>> The steps to achieving this:
>>
>> 1. Drop alarm timers from qemu-timer.c and calculate g_poll() timeout
>> instead for the main loop.
>>
>> 2. Introduce a per-AioContext aio_ctx_clock that can be used with
>> qemu_new_timer() to create a QEMUTimer that expires during
>> aio_poll().
>>
>> 3. Calculate g_poll() timeout for aio_ctx_clock in aio_poll().
>
> A couple of questions:
>
> 1. How would this work where the user has no main loop, e.g. qemu-img? A
> block driver may well still need timers.
The block driver should only use aio_ctx_clock, and those _would_ be
handled in aio_poll().
> 3. Is it safe to anything you can do in a bh in a timer? IE are users every
> going to need to schedule a bh from a timer? If so, this seems a bit
> long winded for users that want bh functionality.
It is safe.
Paolo
next prev parent reply other threads:[~2013-07-17 8:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 16:24 [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves Alex Bligh
2013-07-06 16:31 ` Alex Bligh
2013-07-06 18:04 ` [Qemu-devel] [PATCHv2] " Alex Bligh
2013-07-15 14:25 ` [Qemu-devel] [PATCH] " Paolo Bonzini
2013-07-15 20:15 ` Alex Bligh
2013-07-15 20:53 ` Paolo Bonzini
2013-07-15 23:04 ` Alex Bligh
2013-07-16 6:16 ` Paolo Bonzini
2013-07-16 7:30 ` Alex Bligh
2013-07-16 7:34 ` Paolo Bonzini
2013-07-16 15:29 ` Alex Bligh
2013-07-16 15:43 ` Paolo Bonzini
2013-07-16 16:14 ` Alex Bligh
2013-07-16 16:55 ` Paolo Bonzini
2013-07-16 21:22 ` [Qemu-devel] [PATCHv3] " Alex Bligh
2013-07-16 21:24 ` [Qemu-devel] [PATCH] " Alex Bligh
2013-07-17 3:02 ` Stefan Hajnoczi
2013-07-17 8:07 ` Alex Bligh
2013-07-17 8:11 ` Paolo Bonzini [this message]
2013-07-17 16:09 ` Alex Bligh
2013-07-18 18:48 ` Alex Bligh
2013-07-19 1:58 ` Stefan Hajnoczi
2013-07-19 6:22 ` Paolo Bonzini
2013-07-19 6:38 ` Alex Bligh
2013-07-19 6:51 ` Paolo Bonzini
2013-07-19 17:26 ` [Qemu-devel] [PATCH] [RFC] aio/timers: Drop alarm timers; introduce QEMUClock to AioContext; run timers in aio_poll Alex Bligh
2013-07-25 9:00 ` Stefan Hajnoczi
2013-07-25 9:02 ` Stefan Hajnoczi
2013-07-17 7:50 ` [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6519B.6060609@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.