From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzOxQ-0004vS-Py for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:27:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzOxO-0006fh-Vz for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:27:40 -0400 Message-ID: <51E67198.3080202@adacore.com> Date: Wed, 17 Jul 2013 12:27:36 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1373476202-11277-1-git-send-email-chouteau@adacore.com> <1373476202-11277-3-git-send-email-chouteau@adacore.com> <20130716020617.GA22542@home.buserror.net> <51E5669C.2080602@adacore.com> <51E568A3.4090503@suse.de> <51E571B7.2060308@adacore.com> <1373993688.8183.328@snotra> <51E654B0.2060400@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Scott Wood , "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" On 07/17/2013 10:29 AM, Alexander Graf wrote: > > > Am 17.07.2013 um 10:24 schrieb Fabien Chouteau : > >> On 07/16/2013 06:54 PM, Scott Wood wrote: >>> On 07/16/2013 11:15:51 AM, Fabien Chouteau wrote: >>>> On 07/16/2013 05:37 PM, Alexander Graf wrote: >>>>> On 07/16/2013 05:28 PM, Fabien Chouteau wrote: >>>>>> On 07/16/2013 04:06 AM, Scott Wood wrote: >>>>>>> On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >>>>>>>> + /* ring_base = (etsec->regs[RBASEH].value& 0xF)<< 32; */ >>>>>>>> + ring_base += etsec->regs[RBASE0 + ring_nbr].value& ~0x7; >>>>>>>> + start_bd_addr = bd_addr = etsec->regs[RBPTR0 + ring_nbr].value& ~0x7; >>>>>>> What about RBDBPH (upper bits of physical address)? Likewise for TX. >>>>>> I'm only interested in 32bits address spaces, so RBASEH, TBASEH, RBDBPH or TBDBPH. >>>>> >>>>> Why? I thought e500mc and above can access more than 32bits of physical address space? >>>> >>>> Yes but this is not emulated by QEMU, right? sizeof (hwaddr) for >>>> qemu-system-ppc is 8... >>> >>> 36bit physical is emulated by QEMU. Currently we put CCSR in a place that would make it difficult to use memory above 4G, but that should change at some point. >> >> >> But hwaddr is 32 bits, how could you call cpu_physical_memory_read()? to >> a 36bits address? > > 8 x 8 = 64, no? :) > Oups, I was so sure of myself :) -- Fabien Chouteau