From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] cifs: extend the buffer length enought for sprintf() using Date: Thu, 18 Jul 2013 09:08:24 +0800 Message-ID: <51E74008.8050308@asianux.com> References: <51E5E9DA.8020603@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Steve French , Jeff Layton , "sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org" , linux-cifs , samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org To: Scott Lovenberg Return-path: In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 07/18/2013 02:27 AM, Scott Lovenberg wrote: > On Tue, Jul 16, 2013 at 10:06 PM, Steve French wrote: > >>> If this is correct for the domain size, MAX_DOMAIN_SIZE in the >>> cifs-utils mount helper (mount.cifs.c) has to be changed. It is >>> currently 64 + null terminator. I can open a bug and patch it if this >>> is correct. >>> >>> CC'ing Jeff Layton since he maintains the cifs-utils package. >>> >>> -- >>> Peace and Blessings, >>> -Scott. >> >> http://support.microsoft.com/kb/909264 indicates that (at least for >> Microsoft) domain names can be considerably longer than 64 bytes, so >> this patch seems reasonable. Merged into cifs-2.6.git - if anyone >> objects or wants to add ack/reviewed let me know. >> >> >> "The maximum length of ... the fully qualified domain name (FQDN) is >> 63 octets per label and 255 bytes per FQDN. This maximum includes 254 >> bytes for the FQDN and one byte for the ending dot." >> >> >> -- >> Thanks, >> >> Steve > > Thanks, Steve. I'll patch this tonight. > Firstly, thank you for your work. Hmm... could you please wait for 1-2 days so can let this patch given more checking by another contributors ? If possible, after finish discussing, I should/will send patch v2 for it. Is it OK ? > > -- > Peace and Blessings, > -Scott. > > Thanks. -- Chen Gang