From: "Egger, Christoph" <chegger@amazon.de>
To: Tim Deegan <tim@xen.org>
Cc: suravee.suthikulpanit@amd.com, Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1 V3] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr
Date: Thu, 18 Jul 2013 10:14:24 +0200 [thread overview]
Message-ID: <51E7A3E0.4080306@amazon.de> (raw)
In-Reply-To: <20130717194359.GB80836@ocelot.phlegethon.org>
On 17.07.13 21:43, Tim Deegan wrote:
>> I'm not clear about the need for this new wrapper: Is it really
>> benign to the caller what type, access, and order get returned
>> here? Is it really too much of a burden to have the two call
>> sites do the call here directly? The more that (see above) you'd
>> really need to give the caller control over the access requested?
>
> Yeah, I'm not sure the wrapper is needed. Can the callers just use
> get_page_from_gfn() to do the translation from guest-MFN -- i.e. will we
> always be in non-nested mode when we're emulating VMLOAD/VMSAVE?
When you run an L2 hypervisor then you are in nested mode.
Christoph
next prev parent reply other threads:[~2013-07-18 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 17:34 [PATCH 1/1 V3] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr suravee.suthikulpanit
2013-07-12 8:01 ` Jan Beulich
2013-07-15 21:17 ` Suravee Suthikulanit
2013-07-16 6:55 ` Jan Beulich
2013-07-17 19:43 ` Tim Deegan
2013-07-18 8:14 ` Egger, Christoph [this message]
2013-07-18 8:24 ` Egger, Christoph
2013-07-18 16:41 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E7A3E0.4080306@amazon.de \
--to=chegger@amazon.de \
--cc=JBeulich@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.