From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables-nftables - PATCH 1/2] nft: Optimize chain listing if only one is looked for
Date: Thu, 18 Jul 2013 14:10:51 +0300 [thread overview]
Message-ID: <51E7CD3B.9020400@linux.intel.com> (raw)
In-Reply-To: <20130717134004.GA7893@localhost>
Hi Pablo,
>> + if (chain && strcmp(chain, chain_name) != 0)
> This should be == 0. There's the same checking above __nft_rule_list.
>
> I noticed that we don't need to strcmp(chain, chain_name) again,
> checking for chain is sufficient.
Indeed, was not really awaken. Thanks for fixing further.
Tomasz
next prev parent reply other threads:[~2013-07-18 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 7:34 [iptables-nftables - PATCH 0/2] fixes Tomasz Bursztyka
2013-07-17 7:34 ` [iptables-nftables - PATCH 1/2] nft: Optimize chain listing if only one is looked for Tomasz Bursztyka
2013-07-17 13:40 ` Pablo Neira Ayuso
2013-07-18 11:10 ` Tomasz Bursztyka [this message]
2013-07-17 7:34 ` [iptables-nftables - PATCH 2/2] nft: Fix code style issues Tomasz Bursztyka
2013-07-17 13:47 ` Pablo Neira Ayuso
2013-07-18 11:12 ` Tomasz Bursztyka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E7CD3B.9020400@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.