From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uznqb-0006Je-Um for qemu-devel@nongnu.org; Thu, 18 Jul 2013 09:02:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UznqY-0004Zn-GM for qemu-devel@nongnu.org; Thu, 18 Jul 2013 09:02:17 -0400 Message-ID: <51E7E753.3080605@redhat.com> Date: Thu, 18 Jul 2013 07:02:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374151939-3883-1-git-send-email-kwolf@redhat.com> <20130718125548.GL3582@dhcp-200-207.str.redhat.com> In-Reply-To: <20130718125548.GL3582@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CCqRK7rxTiPk67WhbTTgDFjahJucuAThw" Subject: Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CCqRK7rxTiPk67WhbTTgDFjahJucuAThw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2013 06:55 AM, Kevin Wolf wrote: > Am 18.07.2013 um 14:52 hat Kevin Wolf geschrieben: >> Even if the VM is already stopped, we cannot assume that all data has >> already been successfully flushed to disk. The flush during the previo= us >> vm_stop() could have failed. >> >> Run bdrv_flush_all() unconditionally so that we get an error each time= >> if the block device isn't really flushed. >> >=20 > Oops, forgot it again: >=20 > Cc: qemu-stable@nongnu.org >=20 >> Signed-off-by: Kevin Wolf >> --- >> cpus.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CCqRK7rxTiPk67WhbTTgDFjahJucuAThw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR5+dTAAoJEKeha0olJ0NqZN4H/jxyHb/eWCXPwfUW7aL3P965 r0vC6qCS23qElpmVi91Wz23X9puUqs6mVvnigP7imTDSGiVL8cmz5kcFA+I/9830 t0fjugmzucMGaGcRu1u+0l0B03nrR9dGRVL1XQHCcnua46/midMs2Hx3dTlvMA3J WsrooKpEKXTaNvNRerkDjPaUzLNl+6FXZB93DwKxrgIcibN7EbJ+rt5yZwRqzHvp nM/+hN08Vzon8uztpPB6HGR0fz42Fcg5oaevTsZx8aUJ140Or2/hizgp6pEZw0VD rfzjA9LUq7l6Ul1vgVxB5eQM4DtQwdRAMaRvlAjrEdVkqJyxaJPd3YTXhtNO6Ho= =ueuH -----END PGP SIGNATURE----- --CCqRK7rxTiPk67WhbTTgDFjahJucuAThw--