All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Alban Browaeys <alban.browaeys@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	linux-media@vger.kernel.org, Alban Browaeys <prahal@yahoo.com>
Subject: Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.
Date: Thu, 18 Jul 2013 17:13:38 +0200	[thread overview]
Message-ID: <51E80622.3020803@googlemail.com> (raw)
In-Reply-To: <1374015476-26197-1-git-send-email-prahal@yahoo.com>

Am 17.07.2013 00:57, schrieb Alban Browaeys:
> Set the config structure pointer to the eeprom data pointer (data,
> here eedata dereferenced) not the pointer to the pointer to
> the eeprom data (eedata itself).
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
> index 4851cc2..c4ff973 100644
> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>  
>  	*eedata = data;
>  	*eedata_len = len;
> -	dev_config = (void *)eedata;
> +	dev_config = (void *)*eedata;
>  
>  	switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>  	case 0:
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>

Thanks,
Frank

  reply	other threads:[~2013-07-18 15:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 22:57 [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data Alban Browaeys
2013-07-18 15:13 ` Frank Schäfer [this message]
2013-07-18 15:51   ` Antti Palosaari
2013-07-18 16:37     ` Frank Schäfer
2013-07-26 13:23 ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E80622.3020803@googlemail.com \
    --to=fschaefer.oss@googlemail.com \
    --cc=alban.browaeys@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=prahal@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.