From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, gaowanlong@cn.fujitsu.com
Subject: Re: [Qemu-devel] [RFC 1/6] OptsVisitor: introduce basic list modes
Date: Thu, 18 Jul 2013 17:45:44 +0200 [thread overview]
Message-ID: <51E80DA8.1080803@redhat.com> (raw)
In-Reply-To: <51E8017C.2000900@redhat.com>
On 07/18/13 16:53, Paolo Bonzini wrote:
> Il 18/07/2013 15:59, Laszlo Ersek ha scritto:
>> + default:
>> + assert(0);
>
> "abort()" to avoid excessively punishing folks who use -DNDEBUG (and
> also to ensure they do not get extra compiler warnings).
>
> Otherwise looks good!
Yeah I hesitated between these two. Will fix.
Thanks,
Laszlo
next prev parent reply other threads:[~2013-07-18 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 13:59 [Qemu-devel] [RFC 0/6] OptsVisitor: support / flatten integer ranges for repeating options Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 1/6] OptsVisitor: introduce basic list modes Laszlo Ersek
2013-07-18 14:53 ` Paolo Bonzini
2013-07-18 15:45 ` Laszlo Ersek [this message]
2013-07-18 13:59 ` [Qemu-devel] [RFC 2/6] OptsVisitor: introduce list modes for interval flattening Laszlo Ersek
2013-07-18 14:56 ` Paolo Bonzini
2013-07-18 15:57 ` Laszlo Ersek
2013-07-18 16:03 ` Paolo Bonzini
2013-07-18 16:14 ` Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 3/6] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 4/6] OptsVisitor: rebase opts_type_uint64() to parse_uint_full() Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 5/6] OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS Laszlo Ersek
2013-07-18 13:59 ` [Qemu-devel] [RFC 6/6] OptsVisitor: don't try to flatten overlong integer ranges Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E80DA8.1080803@redhat.com \
--to=lersek@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.