From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning
Date: Thu, 18 Jul 2013 10:09:36 -0700 [thread overview]
Message-ID: <51E82150.5070806@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_crhJopBsB-cby8n2piKBh=5u+=xMoW+UrSUSUdsbM6g@mail.gmail.com>
On 07/18/2013 09:36 AM, Peter Maydell wrote:
> On 18 July 2013 17:14, Richard Henderson <rth@twiddle.net> wrote:
>> At -O2, code in the form
>>
>> if (p) A; B; if (p) C;
>>
>> may be rearranged via "jump threading" into
>>
>> if (p) { A; B; C; } else { B; }
>>
>> But at -O1 this doesn't happen and we -Werror out here on
>> the "may be used uninitialized" orig_len. Perform this transform
>> by hand so that -O1 remains a viable debugging alternative.
>>
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>
> This is the same issue fixed by this (reviewed but
> never applied) patch from June, isn't it?
>
> http://patchwork.ozlabs.org/patch/251410/
Yes, it is.
r~
prev parent reply other threads:[~2013-07-18 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 16:14 [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning Richard Henderson
2013-07-18 16:36 ` Peter Maydell
2013-07-18 17:09 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E82150.5070806@twiddle.net \
--to=rth@twiddle.net \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.