Re: [PATCH 2/3] tracing: use trace_seq_puts()/trace_seq_putc() where possible

["zhangwei(Jovi)" <jovi.zhangwei@huawei.com>]

On 2013/7/19 9:29, Steven Rostedt wrote:
> On Mon, 2013-07-15 at 16:32 +0800, zhangwei(Jovi) wrote:
>> diff --git a/kernel/trace/trace_functions_graph.c
>> b/kernel/trace/trace_functions_graph.c
>> index 8388bc9..3793f90 100644
>> --- a/kernel/trace/trace_functions_graph.c
>> +++ b/kernel/trace/trace_functions_graph.c
>> @@ -446,7 +446,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid)
>>
>>         /* First spaces to align center */
>>         for (i = 0; i < spaces / 2; i++) {
>> -               ret = trace_seq_printf(s, " ");
>> +               ret = trace_seq_putc(s, ' ');
>>                 if (!ret)
>>                         return TRACE_TYPE_PARTIAL_LINE;
>>         }
>> @@ -457,7 +457,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid)
>>
>>         /* Last spaces to align center */
>>         for (i = 0; i < spaces - (spaces / 2); i++) {
>> -               ret = trace_seq_printf(s, " ");
>> +               ret = trace_seq_putc(s, " ");
> 
> Oops, s/"/'/g
> 
> I'll fix it.
> 
Sorry for this, I will open my eyes more larger next time.

jovi