All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	" Mauro Carvalho Chehab" <mchehab@redhat.com>,
	"Pawel Osciak" <pawel@osciak.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	" Ismael Luceno" <ismael.luceno@corp.bluecherry.net>,
	" Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/4] videobuf2-dma-sg: Replace vb2_dma_sg_desc with sg_table
Date: Fri, 19 Jul 2013 10:51:33 +0200	[thread overview]
Message-ID: <51E8FE15.4090604@samsung.com> (raw)
In-Reply-To: <1374220729-8304-3-git-send-email-ricardo.ribalda@gmail.com>

Hi Ricardo,

On 07/19/2013 09:58 AM, Ricardo Ribalda Delgado wrote:
> Replace the private struct vb2_dma_sg_desc with the struct sg_table so
> we can benefit from all the helping functions in lib/scatterlist.c for
> things like allocating the sg or compacting the descriptor
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
[...]
> diff --git a/include/media/videobuf2-dma-sg.h b/include/media/videobuf2-dma-sg.h
> index 0038526..7b89852 100644
> --- a/include/media/videobuf2-dma-sg.h
> +++ b/include/media/videobuf2-dma-sg.h
> @@ -15,16 +15,10 @@
>  
>  #include <media/videobuf2-core.h>
>  
> -struct vb2_dma_sg_desc {
> -	unsigned long		size;
> -	unsigned int		num_pages;
> -	struct scatterlist	*sglist;
> -};

You need to squash patches 3/4, 4/4 into this one to avoid breaking
build and git bisection.

Thanks,
Sylwester


  reply	other threads:[~2013-07-19  8:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  7:58 [PATCH 0/4] videobuf2-dma-sg: Contiguos memory allocation Ricardo Ribalda Delgado
2013-07-19  7:58 ` [PATCH 1/4] videobuf2-dma-sg: Allocate pages as contiguous as possible Ricardo Ribalda Delgado
2013-07-19 12:18   ` Andre Heider
2013-07-19 12:57     ` Ricardo Ribalda Delgado
2013-07-19  7:58 ` [PATCH 2/4] videobuf2-dma-sg: Replace vb2_dma_sg_desc with sg_table Ricardo Ribalda Delgado
2013-07-19  8:51   ` Sylwester Nawrocki [this message]
2013-07-19 12:09     ` Ricardo Ribalda Delgado
2013-07-19  7:58 ` [PATCH 3/4] media/marvell-ccic: Changes on the vb2-dma-sg API Ricardo Ribalda Delgado
2013-07-19  7:58 ` [PATCH 4/4] media/solo6x10: " Ricardo Ribalda Delgado
2013-11-05 22:25   ` Ismael Luceno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E8FE15.4090604@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=corbet@lwn.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ismael.luceno@corp.bluecherry.net \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@redhat.com \
    --cc=pawel@osciak.com \
    --cc=ricardo.ribalda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.