From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Michal Tesar <mtesar@redhat.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl net: Keep tcp_syn_retries inside the boundary
Date: Fri, 19 Jul 2013 18:08:01 +0400 [thread overview]
Message-ID: <51E94841.1020202@cogentembedded.com> (raw)
In-Reply-To: <1374230873-30070-1-git-send-email-mtesar@redhat.com>
Hello.
On 19-07-2013 14:47, Michal Tesar wrote:
> Limit the min/max value passed to the
> /proc/sys/net/ipv4/tcp_syn_retries.
> Signed-off-by: Michal Tesar <mtesar@redhat.com>
> ---
> net/ipv4/sysctl_net_ipv4.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index b2c123c..fdc2a17 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
[...]
> @@ -332,7 +334,9 @@ static struct ctl_table ipv4_table[] = {
> .data = &sysctl_tcp_syn_retries,
> .maxlen = sizeof(int),
> .mode = 0644,
> - .proc_handler = proc_dointvec
> + .proc_handler = proc_dointvec_minmax,
> + .extra1 = &tcp_syn_retries_min,
> + .extra2 = &tcp_syn_retries_max
You should indent with tabs, not spaces.
WBR, Sergei
prev parent reply other threads:[~2013-07-19 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 10:47 [PATCH] sysctl net: Keep tcp_syn_retries inside the boundary Michal Tesar
2013-07-19 14:08 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E94841.1020202@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mtesar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.