All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kwok Cheung Yeung <kcy@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when processing trap exceptions
Date: Fri, 19 Jul 2013 16:09:16 +0100	[thread overview]
Message-ID: <51E9569C.5050400@codesourcery.com> (raw)
In-Reply-To: <CAFEAcA_jASZBOYknbbT6O3wGhM=pPk-o7iUEdRnKcCg7vztE_g@mail.gmail.com>

On 19/07/2013 3:52 PM, Peter Maydell wrote:
> On 19 July 2013 15:47, Kwok Cheung Yeung <kcy@codesourcery.com> wrote:
>> Decode trap instructions during the handling of an EXCP_TRAP according to
>> the current ISA mode.
>>
>> Signed-off-by: Kwok Cheung Yeung <kcy@codesourcery.com>
>> ---
>>   linux-user/main.c | 20 ++++++++++++++++++--
>>   1 file changed, 18 insertions(+), 2 deletions(-)
>>
>> v2: Read microMIPS instructions sequentially as 16-bit values to avoid
>>      endianess issues. Add braces to if statement to conform to formatting
>>      standards.
>
> This code looks OK but last time round I asked about
> EXCP_BREAK -- why doesn't that also need to change?
>

This patch was intended to fix the handling of floating-point exceptions while 
running the GCC unit tests (gcc.c-torture/execute/20101011-1.c) on microMIPS, 
which only requires EXCP_TRAP to work properly. I'll post a version with 
EXCP_BREAK fixed shortly.

Thanks

Kwok

      reply	other threads:[~2013-07-19 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 14:47 [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when processing trap exceptions Kwok Cheung Yeung
2013-07-19 14:52 ` Peter Maydell
2013-07-19 15:09   ` Kwok Cheung Yeung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E9569C.5050400@codesourcery.com \
    --to=kcy@codesourcery.com \
    --cc=aurelien@aurel32.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.