From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V0FuC-0006xi-7x for mharc-qemu-trivial@gnu.org; Fri, 19 Jul 2013 14:59:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Fu8-0006wE-0o for qemu-trivial@nongnu.org; Fri, 19 Jul 2013 14:59:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0Fu6-00031F-HG for qemu-trivial@nongnu.org; Fri, 19 Jul 2013 14:59:47 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Fu6-000314-AL for qemu-trivial@nongnu.org; Fri, 19 Jul 2013 14:59:46 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 27F4D72809FD; Fri, 19 Jul 2013 20:59:44 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7ZUl5jHb-67B; Fri, 19 Jul 2013 20:59:32 +0200 (CEST) Received: from [192.168.178.35] (p54AD9437.dip0.t-ipconnect.de [84.173.148.55]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id 8DF8F72809FC; Fri, 19 Jul 2013 20:59:32 +0200 (CEST) Message-ID: <51E98C93.8010508@weilnetz.de> Date: Fri, 19 Jul 2013 20:59:31 +0200 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: qemu-trivial References: <1373647719-32757-1-git-send-email-sw@weilnetz.de> <51E4E011.70407@weilnetz.de> <51E846AC.5070309@weilnetz.de> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 78.47.199.172 Cc: Anthony Liguori , qemu-devel , Alexander Graf Subject: Re: [Qemu-trivial] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression) X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2013 18:59:49 -0000 Am 19.07.2013 00:40, schrieb Alexander Graf: > On 18.07.2013, at 21:49, Stefan Weil wrote: > >> Am 16.07.2013 07:54, schrieb Stefan Weil: >>> Am 12.07.2013 18:48, schrieb Stefan Weil: >>>> Fix a number of warnings for 32 bit builds (tested on MingW and Linux): >>>> >>>> CC hw/ide/macio.o >>>> qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb': >>>> qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> qemu/hw/ide/macio.c: In function 'pmac_ide_transfer_cb': >>>> qemu/hw/ide/macio.c:215:5: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'int64_t' [-Werror=format] >>>> qemu/hw/ide/macio.c:222:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> qemu/hw/ide/macio.c:264:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> cc1: all warnings being treated as errors >>>> make: *** [hw/ide/macio.o] Error 1 >>>> >>>> Signed-off-by: Stefan Weil >>>> --- >>>> >>>> >>>> >>>> Hi Anthony, >>>> >>>> the patch fixes a build regression which was introduced today. >>>> Could you please apply it without waiting for the next pull requests? >>>> >>>> Thanks, >>>> Stefan [...] > Acked-by: Alexander Graf I assume this can go through > the trivial tree? Or directly get applied by Anthony? Alex I still think that build regressions should be fixed by a direct maintainer commit instead of waiting for a pull request, but obviously this does not happen here (why?). So hopefully the fix will be committed via qemu-trivial at least. See http://patchwork.ozlabs.org/patch/258774/ for the full patch. Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Fu8-0006wD-0C for qemu-devel@nongnu.org; Fri, 19 Jul 2013 14:59:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0Fu5-00030t-G0 for qemu-devel@nongnu.org; Fri, 19 Jul 2013 14:59:47 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=55813 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Fu5-00030Q-9J for qemu-devel@nongnu.org; Fri, 19 Jul 2013 14:59:45 -0400 Message-ID: <51E98C93.8010508@weilnetz.de> Date: Fri, 19 Jul 2013 20:59:31 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1373647719-32757-1-git-send-email-sw@weilnetz.de> <51E4E011.70407@weilnetz.de> <51E846AC.5070309@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial Cc: Anthony Liguori , qemu-devel , Alexander Graf Am 19.07.2013 00:40, schrieb Alexander Graf: > On 18.07.2013, at 21:49, Stefan Weil wrote: > >> Am 16.07.2013 07:54, schrieb Stefan Weil: >>> Am 12.07.2013 18:48, schrieb Stefan Weil: >>>> Fix a number of warnings for 32 bit builds (tested on MingW and Linux): >>>> >>>> CC hw/ide/macio.o >>>> qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb': >>>> qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> qemu/hw/ide/macio.c: In function 'pmac_ide_transfer_cb': >>>> qemu/hw/ide/macio.c:215:5: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'int64_t' [-Werror=format] >>>> qemu/hw/ide/macio.c:222:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> qemu/hw/ide/macio.c:264:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> cc1: all warnings being treated as errors >>>> make: *** [hw/ide/macio.o] Error 1 >>>> >>>> Signed-off-by: Stefan Weil >>>> --- >>>> >>>> >>>> >>>> Hi Anthony, >>>> >>>> the patch fixes a build regression which was introduced today. >>>> Could you please apply it without waiting for the next pull requests? >>>> >>>> Thanks, >>>> Stefan [...] > Acked-by: Alexander Graf I assume this can go through > the trivial tree? Or directly get applied by Anthony? Alex I still think that build regressions should be fixed by a direct maintainer commit instead of waiting for a pull request, but obviously this does not happen here (why?). So hopefully the fix will be committed via qemu-trivial at least. See http://patchwork.ozlabs.org/patch/258774/ for the full patch. Stefan