From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nvec keyboard support
Date: Fri, 19 Jul 2013 13:14:13 -0600 [thread overview]
Message-ID: <51E99005.1090008@wwwdotorg.org> (raw)
In-Reply-To: <1374223663-8576-4-git-send-email-danindrey@mail.ru>
On 07/19/2013 02:47 AM, Andrey Danin wrote:
> Signed-off-by: Andrey Danin <danindrey@mail.ru>
(Some patch descriptions would be useful)
> diff --git a/board/compal/dts/tegra20-paz00.dts b/board/compal/dts/tegra20-paz00.dts
> + nvec {
> + compatible = "nvidia,tegra20-nvec";
> + reg = <0x7000c500 0x100>;
> + clock-frequency = <80000>;
> + request-gpios = <&gpio 170 0>; /* gpio PV2 */
> + slave-addr = <138>;
> + };
I would rather not propagate this DT binding. We need to fix the binding
to clearly separate the concepts of:
a) The I2C slave controller (which should be a standalone driver for the
Tegra I2C slave HW).
b) The protocol sent over the I2C slave channel (which would be specific
to NVEC, implement the GPIO hand-shaking, etc.).
c) The devices that communicate over the protocol (keyboard in this case).
I suspect we need separate DT nodes/sub-nodes for all of those, and a
method of hooking them all together.
next prev parent reply other threads:[~2013-07-19 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 8:47 [U-Boot] [PATCH 0/3] ARM: tegra: add nvec keyboard support for paz00 Andrey Danin
2013-07-19 8:47 ` [U-Boot] [PATCH 1/3] ARM: tegra: add nvec driver Andrey Danin
2013-07-19 16:28 ` Tom Warren
2013-07-19 8:47 ` [U-Boot] [PATCH 2/3] ARM: tegra: add input driver for nvec keyboard Andrey Danin
2013-07-19 8:47 ` [U-Boot] [PATCH 3/3] ARM: tegra: paz00: enable nvec keyboard support Andrey Danin
2013-07-19 19:14 ` Stephen Warren [this message]
2013-07-20 9:12 ` [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboard support Marc Dietrich
2013-07-21 3:20 ` Stephen Warren
2013-07-22 8:09 ` [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboardsupport Marc Dietrich
2013-07-23 15:40 ` Stephen Warren
2013-07-24 17:52 ` Marc Dietrich
2013-07-25 17:40 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E99005.1090008@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.